linux-kernel - Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for resource table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANLsYkyLyROGsUuzaxA7Kx2ouj48NHM1t84DeyOiJmDiDMTgHA@mail.gmail.com>
Date:   Fri, 25 Mar 2022 10:02:00 -0600
From:   Mathieu Poirier <mathieu.poirier@...aro.org>
To:     Peng Fan <peng.fan@....com>
Cc:     "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "bjorn.andersson@...aro.org" <bjorn.andersson@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for
 resource table

On Thu, 24 Mar 2022 at 20:02, Peng Fan <peng.fan@....com> wrote:
>
> Hi Mathieu,
>
> > Subject: Re: [PATCH V2] remoteproc: imx_rproc: Ignore create mem entry for
> > resource table
> >
> > On Tue, Mar 08, 2022 at 02:57:54PM +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@....com>
> > >
> > > Resource table will not be used for memory allocation, no need to
> > > create rproc mem entry.
> > >
> > > Fixes: b29b4249f8f0c ("remoteproc: imx_rproc: add i.MX specific parse
> > > fw hook")
> >
> >
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Felixir.b
> > ootlin.com%2Flinux%2Fv5.17%2Fsource%2FDocumentation%2Fprocess%2Fsu
> > bmitting-patches.rst&amp;data=04%7C01%7Cpeng.fan%40nxp.com%7Cae62
> > e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd99c5c301635
> > %7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8eyJW
> > IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> > 3000&amp;sdata=Xod3YxSRW8h2WXdnpu1WX4DzRpCTnYE9gVlt9HXMlnU%3
> > D&amp;reserved=0
>
> Sorry, I could not get your point of which part conflicts with the patch rules.
> Please clarify and I'll improve.

The commitID in the "Fixes" tag should be 12 characters rather than 13
as you have above.

>
> Thanks,
> Peng.
>
>
> >
> >
> > > Signed-off-by: Peng Fan <peng.fan@....com>
> > > ---
> > >
> > > V2:
> > >  Add Fixes tag
> > >  Separate the patch from
> > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> > >
> > hwork.kernel.org%2Fproject%2Flinux-remoteproc%2Fpatch%2F20220111033
> > 333
> > > .403448-7-peng.fan%40oss.nxp.com%2F&amp;data=04%7C01%7Cpeng.fan
> > %40nxp.
> > >
> > com%7Cae62e633010048f972db08da0da89836%7C686ea1d3bc2b4c6fa92cd
> > 99c5c301
> > >
> > 635%7C0%7C1%7C637837315009092474%7CUnknown%7CTWFpbGZsb3d8e
> > yJWIjoiMC4wL
> > >
> > jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&am
> > p;sdata
> > >
> > =CYL9grwXHpUud4qpzFAEijOWv%2BehvefwyZ4aU02wJnw%3D&amp;reserv
> > ed=0
> > >  Address typo
> > >
> > >  drivers/remoteproc/imx_rproc.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/remoteproc/imx_rproc.c
> > > b/drivers/remoteproc/imx_rproc.c index 7a096f1891e6..f2bfc9077c19
> > > 100644
> > > --- a/drivers/remoteproc/imx_rproc.c
> > > +++ b/drivers/remoteproc/imx_rproc.c
> > > @@ -423,6 +423,9 @@ static int imx_rproc_prepare(struct rproc *rproc)
> > >             if (!strcmp(it.node->name, "vdev0buffer"))
> > >                     continue;
> > >
> > > +           if (!strncmp(it.node->name, "rsc-table", strlen("rsc-table")))
> > > +                   continue;
> > > +
> > >             rmem = of_reserved_mem_lookup(it.node);
> > >             if (!rmem) {
> > >                     dev_err(priv->dev, "unable to acquire memory-region\n");
> > > --
> > > 2.30.0
> > >