linux-kernel - Re: [PATCH 2/2] regulator: rt5759: Add support for Richtek RT5759 DCDC converter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Mar 2022 16:05:50 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     ChiYuan Huang <u0084500@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        cy_huang <cy_huang@...htek.com>, gene_chen@...htek.com,
        lkml <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/2] regulator: rt5759: Add support for Richtek RT5759
 DCDC converter

On Fri, Mar 25, 2022 at 04:55:25PM +0100, Krzysztof Kozlowski wrote:

> You mention board, some of_device_get_match_data() so you talk about
> runtime. maybe_unused is not about runtime. It is about build time.

> The code you sent cannot have this structure unused. If you think
> otherwise, please provide argument, but not about runtime (again). You
> can for example build it without OF and see...

If you use of_match_ptr() in the struct device (which is good practice,
didn't check if this driver does it) then that causes the ID table to be
unreferenced as of_match_ptr() compiles to NULL when !OF.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)