linux-kernel - Re: [PATCH] mm: compaction: use helper isolation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220326094327.hofczncyzqyrxdxw@master>
Date:   Sat, 26 Mar 2022 09:43:27 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: compaction: use helper isolation_suitable

On Tue, Mar 22, 2022 at 07:07:50PM +0800, Miaohe Lin wrote:
>Use helper isolation_suitable to check whether page is suitable to isolate
>to simplify the code. Minor readability improvement.
>
>Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Reviewed-by: Wei Yang <richard.weiyang@...il.com>

>---
> mm/compaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/compaction.c b/mm/compaction.c
>index c3e37aa9ff9e..86f34053c39d 100644
>--- a/mm/compaction.c
>+++ b/mm/compaction.c
>@@ -899,7 +899,7 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
> 		 * not falsely conclude that the block should be skipped.
> 		 */
> 		if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages)) {
>-			if (!cc->ignore_skip_hint && get_pageblock_skip(page)) {
>+			if (!isolation_suitable(cc, page)) {
> 				low_pfn = end_pfn;
> 				page = NULL;
> 				goto isolate_abort;
>-- 
>2.23.0

-- 
Wei Yang
Help you, Help me