linux-kernel - Re: [PATCH 2/3] block: factor out common code for part_stat_show() and diskstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6a80995-7af9-3daa-9d5b-ba73f75788be@huawei.com>
Date:   Sat, 26 Mar 2022 09:11:36 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     <axboe@...nel.dk>, <mpatocka@...hat.com>, <snitzer@...hat.com>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <yi.zhang@...wei.com>
Subject: Re: [PATCH 2/3] block: factor out common code for part_stat_show()
 and diskstats_show()

在 2022/03/25 16:46, Christoph Hellwig 写道:
> On Thu, Mar 17, 2022 at 07:26:52PM +0800, Yu Kuai wrote:
>> part_stat_show() and diskstats_show() are very similar, just factor out
>> common code.
> 
> Well, it doesn't really "factor" much, but creates a big and pretty
> unmaintainble macro.  I don't really see the benefit here.

Hi,

Thanks for your advice, I'll remove this patch.

BTW, do you have any suggestion about patch 3 ?

Thanks,
Kuai
> .
>