linux-kernel - Re: [PATCH] cs423x: cs4236: fix an incorrect NULL check on list iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hwngflrqo.wl-tiwai@suse.de>
Date:   Sun, 27 Mar 2022 10:33:19 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Xiaomeng Tong <xiam0nd.tong@...il.com>
Cc:     perex@...ex.cz, tiwai@...e.com, krzysztof.h1@...pl,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] cs423x: cs4236: fix an incorrect NULL check on list iterator

On Sun, 27 Mar 2022 08:08:22 +0200,
Xiaomeng Tong wrote:
> 
> The bug is here:
> 	err = snd_card_cs423x_pnp(dev, card->private_data, pdev, cdev);
> 
> The list iterator value 'cdev' will *always* be set and non-NULL
> by list_for_each_entry(), so it is incorrect to assume that the
> iterator value will be NULL if the list is empty or no element
> is found.
> 
> To fix the bug, use a new variable 'iter' as the list iterator,
> while use the original variable 'cdev' as a dedicated pointer
> to point to the found element. And snd_card_cs423x_pnp() itself
> has NULL check for cdev.
> 
> Cc: stable@...r.kernel.org
> Fixes: c2b73d1458014 ("ALSA: cs4236: cs4232 and cs4236 driver merge to solve PnP BIOS detection")
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@...il.com>

Thanks, applied now.


Takashi