linux-kernel - Re: [PATCH] RISC-V-fixes: relocate DTB if it's outside memory region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <941622f4f76ecd5bc071e310479b3ad3@mailhost.ics.forth.gr>
Date:   Sun, 27 Mar 2022 11:52:11 +0300
From:   Nick Kossifidis <mick@....forth.gr>
To:     Conor.Dooley@...rochip.com
Cc:     mick@....forth.gr, palmer@...belt.com,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        paul.walmsley@...ive.com, aou@...s.berkeley.edu
Subject: Re: [PATCH] RISC-V-fixes: relocate DTB if it's outside memory region

Στις 2022-03-24 11:37, Conor.Dooley@...rochip.com έγραψε:
> On 22/03/2022 13:28, Nick Kossifidis wrote:
>> In case the DTB provided by the bootloader/BootROM is before the 
>> kernel
>> image or outside /memory, we won't be able to access it through the
>> linear mapping, and get a segfault on setup_arch(). Currently OpenSBI
>> relocates DTB but that's not always the case (e.g. if FW_JUMP_FDT_ADDR
>> is not specified), and it's also not the most portable approach since
>> the default FW_JUMP_FDT_ADDR of the generic platform relocates the DTB
>> at a specific offset that may not be available. To avoid this 
>> situation
>> copy DTB so that it's visible through the linear mapping.
>> 
>> Signed-off-by: Nick Kossifidis <mick@....forth.gr>
> 
> Albeit in a backport, I tested this on a PolarFire SoC based board.
> So I guess, Tested-by: Conor Dooley <conor.dooley@...rochip.com>
> 
> And a lot cleaner than using create_pgd_mapping in setup_vm_final to do 
> it :)
> 
> Thanks,
> Conor.
> 

Thanks !