linux-kernel - Re: [PATCH] iio: adc: fix for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220327143820.45fc1d6d@jic23-huawei>
Date:   Sun, 27 Mar 2022 14:38:20 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     kbuild-all@...ts.01.org, linux-arm-kernel@...ts.infradead.org,
        Rajnikant Bhojani <rajnikant.bhojani@...inx.com>,
        Michal Simek <monstr@...str.eu>,
        Hyun Kwon <hyun.kwon@...inx.com>,
        Shubhrajyoti Datta <shubhraj@...inx.com>,
        Jean-Francois Dagenais <jeff.dagenais@...il.com>,
        Olivier Dugas <dugaso@...atest.com>,
        Manish Narani <mnarani@...inx.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: fix for_each_child.cocci warnings

On Sat, 26 Mar 2022 09:28:12 +0100 (CET)
Julia Lawall <julia.lawall@...ia.fr> wrote:

> From: kernel test robot <lkp@...el.com>
> 
> For_each_child_of_node should have of_node_put() before return.
> 
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
> 
> CC: Rajnikant Bhojani <rajnikant.bhojani@...inx.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...ia.fr>

The upstream version (in IIO for now, but I'd imagine will hit Linus'
tree in next few days) of this looks rather different (no dt code an more)
so I suspect this fix is for a now dead branch...

Jonathan

> ---
> 
> tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
> head:   1870e0fa79a9d58c6748c34550f3ccea0b515933
> commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/1029] iio: adc: Add Xilinx AMS driver
> :::::: branch date: 35 hours ago
> :::::: commit date: 8 weeks ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  drivers/iio/adc/xilinx-ams.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -920,6 +920,7 @@ static int ams_parse_dt(struct iio_dev *
>  					      ams_channels + num_channels);
>  			if (ret < 0) {
>  				kfree(ams_channels);
> +				of_node_put(child_node);
>  				return ret;
>  			}
>