linux-kernel - [PATCH] watch_queue: free the notes array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 27 Mar 2022 21:19:33 +0530
From:   Anirudh Rayabharam <mail@...rudhrb.com>
To:     David Howells <dhowells@...hat.com>,
        Anirudh Rayabharam <mail@...rudhrb.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     syzbot+25ea042ae28f3888727a@...kaller.appspotmail.com,
        linux-kernel@...r.kernel.org
Subject: [PATCH] watch_queue: free the notes array

__put_watch_queue() frees the individual notifications but doesn't free
the notes array itself causing a memory leak.

Reported by syzbot at:
https://syzkaller.appspot.com/bug?extid=25ea042ae28f3888727a

Fix by adding a kfree().

Fixes: c73be61cede5 ("pipe: Add general notification queue support")
Reported-by: syzbot+25ea042ae28f3888727a@...kaller.appspotmail.com
Tested-by: syzbot+25ea042ae28f3888727a@...kaller.appspotmail.com
Signed-off-by: Anirudh Rayabharam <mail@...rudhrb.com>
---
 kernel/watch_queue.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/watch_queue.c b/kernel/watch_queue.c
index 3990e4df3d7b..230038d4f908 100644
--- a/kernel/watch_queue.c
+++ b/kernel/watch_queue.c
@@ -370,6 +370,7 @@ static void __put_watch_queue(struct kref *kref)
 
 	for (i = 0; i < wqueue->nr_pages; i++)
 		__free_page(wqueue->notes[i]);
+	kfree(wqueue->notes);
 	bitmap_free(wqueue->notes_bitmap);
 
 	wfilter = rcu_access_pointer(wqueue->filter);
-- 
2.35.1