linux-kernel - Re: [PATCH 2/4] hwmon: (asus-ec-sensors) implement locking via the ACPI global lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1607f0d-9d6c-fb55-d0d2-b57e4fdfda23@roeck-us.net>
Date:   Sun, 27 Mar 2022 11:04:15 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Eugene Shalygin <eugene.shalygin@...il.com>
Cc:     darcagn@...tonmail.com, Jean Delvare <jdelvare@...e.com>,
        linux-hwmon@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] hwmon: (asus-ec-sensors) implement locking via the
 ACPI global lock

On 3/27/22 09:21, Eugene Shalygin wrote:
> On Sun, 27 Mar 2022 at 14:15, Eugene Shalygin <eugene.shalygin@...il.com> wrote:
>> +       /* number of board EC sensors */
>> +       u8 nr_sensors;
> 
> Re-added by mistake, will be fixed in the next patch version.
> 
>> +               if (ACPI_FAILURE(status)) {
>> +                       dev_err(dev,
>> +                               "Failed to get hardware access guard AML mutex"
>> +                               "'%s': error %d",
>> +                               mutex_path, status);
> 
> Can't choose between various options to fix this broken string
> literal. Would be thankful, Günter, for a suggestion.
> 

What is the problem other than that the string is split across
multiple lines ? That can easily be fixed by not splitting it,
so you'll have to be more specific.

Guenter