linux-kernel - Re: [PATCH] x86/config: Make the x86 defconfigs a bit more usable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkC1JkTOExpBOY6J@gmail.com>
Date:   Sun, 27 Mar 2022 21:04:06 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Nathan Chancellor <nathan@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Borislav Petkov <bp@...en8.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Will Deacon <will@...nel.org>,
        Waiman Long <longman@...hat.com>,
        Boqun Feng <boqun.feng@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] x86/config: Make the x86 defconfigs a bit more usable


* Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Thu, Mar 24, 2022 at 08:47:27AM -0700, Nathan Chancellor wrote:
> > On Thu, Mar 24, 2022 at 09:31:13AM +0100, Ingo Molnar wrote:
> 
> > > --- a/arch/x86/configs/i386_defconfig
> > > +++ b/arch/x86/configs/i386_defconfig
> 
> > > -# CONFIG_64BIT is not set
> > 
> > I don't think this is right, this is repeating the problem that was
> > fixed by commit 76366050eb1b ("x86/defconfigs: Explicitly unset
> > CONFIG_64BIT in i386_defconfig").
> > 
> > $ make ARCH=i386 savedefconfig
> > 
> > ?
> 
> +1 here, there are still branches in use that have i386 defconfig as
> as base and making this problem again is not okay.

Absolutely - fixed in the latest version.

Thanks,

	Ingo