linux-kernel - Re: [PATCH v1 02/12] dt-bindings: timer: gpt: Add i.MXRT compatible Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Mar 2022 21:06:29 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Jesse Taube <mr.bossman075@...il.com>, linux-imx@....com
Cc:     robh+dt@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, aisheng.dong@....com, stefan@...er.ch,
        linus.walleij@...aro.org, daniel.lezcano@...aro.org,
        tglx@...utronix.de, arnd@...db.de, olof@...om.net, soc@...nel.org,
        linux@...linux.org.uk, abel.vesa@....com, dev@...xeye.de,
        marcel.ziswiler@...adex.com, tharvey@...eworks.com,
        leoyang.li@....com, sebastian.reichel@...labora.com,
        cniedermaier@...electronics.com, clin@...e.com,
        giulio.benetti@...ettiengineering.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v1 02/12] dt-bindings: timer: gpt: Add i.MXRT compatible
 Documentation

On 26/03/2022 15:43, Jesse Taube wrote:
> Both the i.MXRT1170 and 1050 have the same GPT timer as "fsl,imx6dl-gpt"
> Add i.MXRT to the compatible list.
> 
> Signed-off-by: Jesse Taube <Mr.Bossman075@...il.com>
> ---
>  Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index a4f51f46b7a1..716c6afcca1f 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -31,6 +31,8 @@ properties:
>            - enum:
>                - fsl,imx6sl-gpt
>                - fsl,imx6sx-gpt
> +              - fsl,imxrt1050-gpt
> +              - fsl,imxrt1170-gpt
>            - const: fsl,imx6dl-gpt

This looks ok, but your usage looks wrong. Did you test your DTS with
dtbs_check?

For the bindings only change:
Acked-by: Krzysztof Kozlowski <krzk@...nel.org>


Best regards,
Krzysztof