linux-kernel - Re: [PATCH] regulator: wm8994: Add an off-on delay for WM8994 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkDpozx+ZmSWwwH0@sirena.org.uk>
Date:   Sun, 27 Mar 2022 23:48:03 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jonathan Bakker <xc-racer2@...e.ca>
Cc:     Liam Girdwood <lgirdwood@...il.com>, patches@...nsource.cirrus.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: wm8994: Add an off-on delay for WM8994 variant

On Sun, Mar 27, 2022 at 03:15:53PM -0700, Jonathan Bakker wrote:

>  
> +	/* WM8994 requires an off-on delay while others do not */
> +	if (ldo->wm8994->type == WM8994)
> +		wm8994_ldo_desc[id].off_on_delay = 36000;

You shouldn't modify the description - this wouldn't work in the
unusual situation where there were one of these devices and is a
bad pattern to set in case someone copies this to another device
where it's more likely there could be multiple instances.  It is
much better to provide two descriptions and select the one which
is needed at runtime.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)