linux-kernel - Re: [PATCH v9 0/3] drivers: ddcci: upstream DDCCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Mar 2022 09:06:52 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yusuf Khan <yusisamerican@...il.com>
Cc:     linux-kernel@...r.kernel.org, jasowang@...hat.com,
        mikelley@...rosoft.com, mst@...hat.com, javier@...igon.com,
        arnd@...db.de, will@...nel.org, axboe@...nel.dk,
        Christoph Grenz <christophg+lkml@...nz-bonn.de>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v9 0/3] drivers: ddcci: upstream DDCCI driver

On Sat, Mar 26, 2022 at 09:58:42PM -0700, Yusuf Khan wrote:
> This patch upstreams(adds) the DDCCI driver by Christoph Grenz into
> the kernel. The original gitlab page is loacted at https://gitlab
> .com/ddcci-driver-linux/ddcci-driver-linux/-/tree/master.
> 
> DDC/CI is a control protocol for monitor settings supported by most
> monitors since about 2005. A chardev and sysfs interface is provided.
> The seccond patch in this series provides a backlight driver using
> DDC/CI.
> 
> Signed-off-by: Yusuf Khan <yusisamerican@...il.com>
> Signed-off-by: Christoph Grenz <christophg+lkml@...nz-bonn.de>
> ---
> v2: Fix typos.
> 
> v3: Add documentation, move files around, replace semaphores with
> mutexes, and replaced <asm-generic/fcntl.h> with <linux/fcntl.h>.
> "imirkin"(which due to his involvement in the dri-devel irc channel
> I cant help but assume to be a DRM developer) said that the DDC/CI
> bus does not intefere with the buses that DRM is involved with.
> 
> v4: Move some documentation, fix grammer mistakes, remove usages of
> likely(), and clarify some documentation.
> 
> v5: Fix grammer mistakes, remove usages of likely(), and clarify
> some documentation.
> 
> v6: Change contact information to reference Christoph Grenz.
> 
> v7: Remove all instances of the unlikely() macro.
> 
> v8: Modify documentation to provide updated date and kernel
> documentation, fix SPDX lines, use isalpha instead of redefining
> logic, change maximum amount of bytes that can be written to be
> conformant with DDC/CI specification, prevent userspace from holding
> locks with the open file descriptor, remove ddcci_cdev_seek, dont
> refine sysfs_emit() logic, use EXPORT_SYMBOL_GPL instead of
> EXPORT_SYMBOL, remove ddcci_device_remove_void, remove module
> paramaters and version, and split into 2 patches.
> 
> v9: Fix IS_ANY_ID matching for compilers and archs where char is
> unsigned char and use the cannonical patch format.
> Reported-by: kernel test robot <lkp@...el.com>

You sent 3 patches with all the same subject line, yet they did
different things.  That's not ok at all.  Please read the kernel
documentation for how to write proper subject lines.

thanks,

greg k-h