linux-kernel - Re: [PATCH v2] ath9k: initialize arrays at compile time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878rsu5be8.fsf@toke.dk>
Date:   Mon, 28 Mar 2022 17:45:19 +0200
From:   Toke Høiland-Jørgensen <toke@...e.dk>
To:     trix@...hat.com, kvalo@...nel.org, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tom Rix <trix@...hat.com>
Subject: Re: [PATCH v2] ath9k: initialize arrays at compile time

trix@...hat.com writes:

> From: Tom Rix <trix@...hat.com>
>
> Early clearing of arrays with
> memset(array, 0, size);
> is equivilent to initializing the array in its decl with
> array[size] = {};
>
> Convert the memsets to initializations.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

The changes LGTM. However, the patch doesn't apply cleanly; could you
please rebase against the ath-next branch[0] and resubmit?

-Toke

[0] https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/log/?h=ath-next