linux-kernel - Re: [PATCH] media: media.h: remove unneeded <stdint.h> inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YkHgim83Q7s9jx6p@pendragon.ideasonboard.com>
Date:   Mon, 28 Mar 2022 19:21:30 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH] media: media.h: remove unneeded <stdint.h> inclusion

Hi Yamada-san,

Thank you for the patch.

On Tue, Mar 29, 2022 at 01:01:53AM +0900, Masahiro Yamada wrote:
> Commit b3b7a9f138b7 ("[media] media-device: Use u64 ints for pointers")
> added this #include <stdint.h>, presumably in order to use uintptr_t.
> 
> Now that it is gone, we can compile this for userspace without <stdint.h>.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
> 
>  include/uapi/linux/media.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index 200fa8462b90..5754dce922a7 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -20,9 +20,6 @@
>  #ifndef __LINUX_MEDIA_H
>  #define __LINUX_MEDIA_H
>  
> -#ifndef __KERNEL__
> -#include <stdint.h>
> -#endif
>  #include <linux/ioctl.h>
>  #include <linux/types.h>
>  

-- 
Regards,

Laurent Pinchart