linux-kernel - Re: [PATCH v6 15/22] erofs: register cookie context for bootstrap blob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Mar 2022 11:15:19 +0800
From:   JeffleXu <jefflexu@...ux.alibaba.com>
To:     dhowells@...hat.com, linux-cachefs@...hat.com, xiang@...nel.org,
        chao@...nel.org, linux-erofs@...ts.ozlabs.org,
        torvalds@...ux-foundation.org, gregkh@...uxfoundation.org,
        willy@...radead.org, linux-fsdevel@...r.kernel.org,
        joseph.qi@...ux.alibaba.com, bo.liu@...ux.alibaba.com,
        tao.peng@...ux.alibaba.com, gerry@...ux.alibaba.com,
        eguan@...ux.alibaba.com, linux-kernel@...r.kernel.org,
        luodaowen.backend@...edance.com, tianzichen@...ishou.com,
        fannaihao@...du.com
Subject: Re: [PATCH v6 15/22] erofs: register cookie context for bootstrap
 blob



On 3/28/22 11:04 AM, Gao Xiang wrote:
> On Fri, Mar 25, 2022 at 08:22:16PM +0800, Jeffle Xu wrote:
>> Registers fscache_cookie for the bootstrap blob file. The bootstrap blob
>> file can be specified by a new mount option, which is going to be
>> introduced by a following patch.
>>
>> Something worth mentioning about the cleanup routine.
>>
>> 1. The init routine is prior to when the root inode gets initialized,
>> and thus the corresponding cleanup routine shall be placed inside
>> .kill_sb() callback.
>>
>> 2. The init routine will instantiate anonymous inodes under the
>> super_block, and thus .put_super() callback shall also contain the
>> cleanup routine. Or we'll get "VFS: Busy inodes after unmount." warning.
>>
>> Signed-off-by: Jeffle Xu <jefflexu@...ux.alibaba.com>
>> ---
>>  fs/erofs/internal.h |  3 +++
>>  fs/erofs/super.c    | 17 +++++++++++++++++
>>  2 files changed, 20 insertions(+)
>>
>> diff --git a/fs/erofs/internal.h b/fs/erofs/internal.h
>> index 459f31803c3b..d8c886a7491e 100644
>> --- a/fs/erofs/internal.h
>> +++ b/fs/erofs/internal.h
>> @@ -73,6 +73,7 @@ struct erofs_mount_opts {
>>  	/* threshold for decompression synchronously */
>>  	unsigned int max_sync_decompress_pages;
>>  #endif
>> +	char *tag;
>>  	unsigned int mount_opt;
>>  };
>>  
>> @@ -151,6 +152,8 @@ struct erofs_sb_info {
>>  	/* sysfs support */
>>  	struct kobject s_kobj;		/* /sys/fs/erofs/<devname> */
>>  	struct completion s_kobj_unregister;
>> +
>> +	struct erofs_fscache *bootstrap;
> 
> the concept of bootstrap is nydus-specific. Actually here we need
> a fscache context of the primary device.
> 
> So I prefer struct erofs_fscache *s_fscache;
> 
> Also please help revise the subject and commit message about
> bootstrap.
> 

OK, will be done in the next version.


-- 
Thanks,
Jeffle