| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Mar 2022 00:50:25 +0800
From: kernel test robot <lkp@...el.com>
To: Helge Deller <deller@....de>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [deller-parisc:for-next 11/14] kernel/irq/cpuhotplug.c:155:6:
warning: no previous prototype for 'irq_migrate_all_off_this_cpu'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git for-next
head: d2d1f1e2e989e1f0369d6c991fec7cd3843979a3
commit: 1d02434051997d499ed9b4fe29fb2992f93f5345 [11/14] parisc: Implement __cpu_die() and __cpu_disable() for CPU hotplugging
config: parisc-randconfig-r004-20220327 (https://download.01.org/0day-ci/archive/20220329/202203290038.b6TKcGbv-lkp@intel.com/config)
compiler: hppa64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?id=1d02434051997d499ed9b4fe29fb2992f93f5345
git remote add deller-parisc https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git
git fetch --no-tags deller-parisc for-next
git checkout 1d02434051997d499ed9b4fe29fb2992f93f5345
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc64 SHELL=/bin/bash kernel/irq/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
>> kernel/irq/cpuhotplug.c:155:6: warning: no previous prototype for 'irq_migrate_all_off_this_cpu' [-Wmissing-prototypes]
155 | void irq_migrate_all_off_this_cpu(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/limits.h:6,
from include/linux/kernel.h:16,
from include/linux/interrupt.h:6,
from kernel/irq/cpuhotplug.c:12:
>> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void'
8 | #define NULL ((void *)0)
| ^~~~
include/linux/irq.h:620:41: note: in expansion of macro 'NULL'
620 | # define irq_affinity_online_cpu NULL
| ^~~~
kernel/irq/cpuhotplug.c:218:5: note: in expansion of macro 'irq_affinity_online_cpu'
218 | int irq_affinity_online_cpu(unsigned int cpu)
| ^~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/stddef.h:8:23: error: expected ')' before numeric constant
8 | #define NULL ((void *)0)
| ^
include/linux/irq.h:620:41: note: in expansion of macro 'NULL'
620 | # define irq_affinity_online_cpu NULL
| ^~~~
kernel/irq/cpuhotplug.c:218:5: note: in expansion of macro 'irq_affinity_online_cpu'
218 | int irq_affinity_online_cpu(unsigned int cpu)
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/irq/cpuhotplug.c:189:13: warning: 'irq_restore_affinity_of_irq' defined but not used [-Wunused-function]
189 | static void irq_restore_affinity_of_irq(struct irq_desc *desc, unsigned int cpu)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/irq_migrate_all_off_this_cpu +155 kernel/irq/cpuhotplug.c
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 144
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 145 /**
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 146 * irq_migrate_all_off_this_cpu - Migrate irqs away from offline cpu
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 147 *
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 148 * The current CPU has been marked offline. Migrate IRQs off this CPU.
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 149 * If the affinity settings do not allow other CPUs, force them onto any
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 150 * available CPU.
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 151 *
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 152 * Note: we must iterate over all IRQs, whether they have an attached
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 153 * action structure or not, as we need to get chained interrupts too.
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 154 */
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 @155 void irq_migrate_all_off_this_cpu(void)
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 156 {
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 157 struct irq_desc *desc;
0dd945ff4647a1 Thomas Gleixner 2017-06-20 158 unsigned int irq;
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 159
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 160 for_each_active_irq(irq) {
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 161 bool affinity_broken;
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 162
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 163 desc = irq_to_desc(irq);
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 164 raw_spin_lock(&desc->lock);
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 165 affinity_broken = migrate_one_irq(desc);
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 166 raw_spin_unlock(&desc->lock);
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 167
0dd945ff4647a1 Thomas Gleixner 2017-06-20 168 if (affinity_broken) {
88ffe2d0a55a16 Lee Jones 2021-08-16 169 pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n",
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 170 irq, smp_processor_id());
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 171 }
0dd945ff4647a1 Thomas Gleixner 2017-06-20 172 }
f1e0bb0ad473a3 Yang Yingliang 2015-09-24 173 }
c5cb83bb337c25 Thomas Gleixner 2017-06-20 174
:::::: The code at line 155 was first introduced by commit
:::::: f1e0bb0ad473a32d1b7e6d285ae9f7e47710bb5e genirq: Introduce generic irq migration for cpu hotunplug
:::::: TO: Yang Yingliang <yangyingliang@...wei.com>
:::::: CC: Thomas Gleixner <tglx@...utronix.de>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists