linux-kernel - Re: [PATCH 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35d98937-40cb-7f57-ab53-49153aa5ce7d@kernel.org>
Date:   Mon, 28 Mar 2022 20:52:02 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     wangseok.lee@...sung.com,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "kishon@...com" <kishon@...com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jesper.nilsson@...s.com" <jesper.nilsson@...s.com>,
        "lars.persson@...s.com" <lars.persson@...s.com>
Cc:     "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "kw@...ux.com" <kw@...ux.com>,
        "linux-arm-kernel@...s.com" <linux-arm-kernel@...s.com>,
        "kernel@...s.com" <kernel@...s.com>,
        전문기 <moonki.jun@...sung.com>
Subject: Re: [PATCH 3/5] PCI: axis: Add ARTPEC-8 PCIe controller driver

On 28/03/2022 04:14, 이왕석 wrote:
> Add support Axis, ARTPEC-8 SoC.
> ARTPEC-8 is the SoC platform of Axis Communications.
> This is based on arm64 and support GEN4 & 2lane.
> This PCIe controller is based on DesignWare Hardware core
> and uses DesignWare core functions to implement the driver.
> This is based on driver/pci/controller/dwc/pci-exynos.c
> 
> Signed-off-by: Wangseok Lee <wangseok.lee@...sung.com>
> ---
>  drivers/pci/controller/dwc/Kconfig        |  31 +
>  drivers/pci/controller/dwc/Makefile       |   1 +
>  drivers/pci/controller/dwc/pcie-artpec8.c | 912 ++++++++++++++++++++++++++++++
>  3 files changed, 944 insertions(+)
>  create mode 100644 drivers/pci/controller/dwc/pcie-artpec8.c
> 

I took a look at the your driver and at existing PCIe Exynos driver.
Unfortunately PCIe Exynos driver is in poor shape, really poor. This
would explain that maybe it's better to have new driver instead of
merging them, especially that hardware is different. Although I am still
waiting for some description of these differences...

I said that Exynos PCIe looks poor... but what is worse, it looks like
you based on it so you copied or some bad patterns it had.

Except this the driver has several coding style issues, so please be
sure to run checkpatch, sparse and smatch before sending it.

Please work on this driver to make it close to Linux coding style, so
there will be no need for us, reviewers, focus on basic stuff.

Optionally, send all this to staging. :)

Best regards,
Krzysztof