| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Mar 2022 13:23:06 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Benjamin Stürz <benni@...erz.xyz>
CC: <loic.poulain@...aro.org>, Kalle Valo <kvalo@...nel.org>,
<davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
<wcn36xx@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/22 v2] wcn36xx: Improve readability of
wcn36xx_caps_name
(apologies for top-posting)
When you submit new patches you should not do so as a reply, but instead
as a new thread with a new version number.
And since multiple folks have suggested that you submit on a
per-subsystem basis I suggest that you re-send this as a singleton just
to wcn36xx@...ts.infradead.org and linux-wireless@...r.kernel.org along
with the associated maintainers.
So I believe [PATCH v3] wcn36xx:... would be the correct subject, but
I'm sure Kalle will let us know otherwise
On 3/28/2022 11:38 AM, Benjamin Stürz wrote:
> Make the array more readable and easier to maintain.
>
Reviewed-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> Signed-off-by: Benjamin Stürz <benni@...erz.xyz>
> ---
> drivers/net/wireless/ath/wcn36xx/main.c | 126 ++++++++++++------------
> 1 file changed, 65 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/main.c
> b/drivers/net/wireless/ath/wcn36xx/main.c
> index 95ea7d040d8c..ac9465dfae64 100644
> --- a/drivers/net/wireless/ath/wcn36xx/main.c
> +++ b/drivers/net/wireless/ath/wcn36xx/main.c
> @@ -192,70 +192,74 @@ static inline u8 get_sta_index(struct
> ieee80211_vif *vif,
> sta_priv->sta_index;
> }
>
to be safe you may want an #undef here
> +#define DEFINE(s) [s] = #s
> +
> static const char * const wcn36xx_caps_names[] = {
> - "MCC", /* 0 */
> - "P2P", /* 1 */
> - "DOT11AC", /* 2 */
> - "SLM_SESSIONIZATION", /* 3 */
> - "DOT11AC_OPMODE", /* 4 */
> - "SAP32STA", /* 5 */
> - "TDLS", /* 6 */
> - "P2P_GO_NOA_DECOUPLE_INIT_SCAN",/* 7 */
> - "WLANACTIVE_OFFLOAD", /* 8 */
> - "BEACON_OFFLOAD", /* 9 */
> - "SCAN_OFFLOAD", /* 10 */
> - "ROAM_OFFLOAD", /* 11 */
> - "BCN_MISS_OFFLOAD", /* 12 */
> - "STA_POWERSAVE", /* 13 */
> - "STA_ADVANCED_PWRSAVE", /* 14 */
> - "AP_UAPSD", /* 15 */
> - "AP_DFS", /* 16 */
> - "BLOCKACK", /* 17 */
> - "PHY_ERR", /* 18 */
> - "BCN_FILTER", /* 19 */
> - "RTT", /* 20 */
> - "RATECTRL", /* 21 */
> - "WOW", /* 22 */
> - "WLAN_ROAM_SCAN_OFFLOAD", /* 23 */
> - "SPECULATIVE_PS_POLL", /* 24 */
> - "SCAN_SCH", /* 25 */
> - "IBSS_HEARTBEAT_OFFLOAD", /* 26 */
> - "WLAN_SCAN_OFFLOAD", /* 27 */
> - "WLAN_PERIODIC_TX_PTRN", /* 28 */
> - "ADVANCE_TDLS", /* 29 */
> - "BATCH_SCAN", /* 30 */
> - "FW_IN_TX_PATH", /* 31 */
> - "EXTENDED_NSOFFLOAD_SLOT", /* 32 */
> - "CH_SWITCH_V1", /* 33 */
> - "HT40_OBSS_SCAN", /* 34 */
> - "UPDATE_CHANNEL_LIST", /* 35 */
> - "WLAN_MCADDR_FLT", /* 36 */
> - "WLAN_CH144", /* 37 */
> - "NAN", /* 38 */
> - "TDLS_SCAN_COEXISTENCE", /* 39 */
> - "LINK_LAYER_STATS_MEAS", /* 40 */
> - "MU_MIMO", /* 41 */
> - "EXTENDED_SCAN", /* 42 */
> - "DYNAMIC_WMM_PS", /* 43 */
> - "MAC_SPOOFED_SCAN", /* 44 */
> - "BMU_ERROR_GENERIC_RECOVERY", /* 45 */
> - "DISA", /* 46 */
> - "FW_STATS", /* 47 */
> - "WPS_PRBRSP_TMPL", /* 48 */
> - "BCN_IE_FLT_DELTA", /* 49 */
> - "TDLS_OFF_CHANNEL", /* 51 */
> - "RTT3", /* 52 */
> - "MGMT_FRAME_LOGGING", /* 53 */
> - "ENHANCED_TXBD_COMPLETION", /* 54 */
> - "LOGGING_ENHANCEMENT", /* 55 */
> - "EXT_SCAN_ENHANCED", /* 56 */
> - "MEMORY_DUMP_SUPPORTED", /* 57 */
> - "PER_PKT_STATS_SUPPORTED", /* 58 */
> - "EXT_LL_STAT", /* 60 */
> - "WIFI_CONFIG", /* 61 */
> - "ANTENNA_DIVERSITY_SELECTION", /* 62 */
> + DEFINE(MCC),
> + DEFINE(P2P),
> + DEFINE(DOT11AC),
> + DEFINE(SLM_SESSIONIZATION),
> + DEFINE(DOT11AC_OPMODE),
> + DEFINE(SAP32STA),
> + DEFINE(TDLS),
> + DEFINE(P2P_GO_NOA_DECOUPLE_INIT_SCAN),
> + DEFINE(WLANACTIVE_OFFLOAD),
> + DEFINE(BEACON_OFFLOAD),
> + DEFINE(SCAN_OFFLOAD),
> + DEFINE(ROAM_OFFLOAD),
> + DEFINE(BCN_MISS_OFFLOAD),
> + DEFINE(STA_POWERSAVE),
> + DEFINE(STA_ADVANCED_PWRSAVE),
> + DEFINE(AP_UAPSD),
> + DEFINE(AP_DFS),
> + DEFINE(BLOCKACK),
> + DEFINE(PHY_ERR),
> + DEFINE(BCN_FILTER),
> + DEFINE(RTT),
> + DEFINE(RATECTRL),
> + DEFINE(WOW),
> + DEFINE(WLAN_ROAM_SCAN_OFFLOAD),
> + DEFINE(SPECULATIVE_PS_POLL),
> + DEFINE(SCAN_SCH),
> + DEFINE(IBSS_HEARTBEAT_OFFLOAD),
> + DEFINE(WLAN_SCAN_OFFLOAD),
> + DEFINE(WLAN_PERIODIC_TX_PTRN),
> + DEFINE(ADVANCE_TDLS),
> + DEFINE(BATCH_SCAN),
> + DEFINE(FW_IN_TX_PATH),
> + DEFINE(EXTENDED_NSOFFLOAD_SLOT),
> + DEFINE(CH_SWITCH_V1),
> + DEFINE(HT40_OBSS_SCAN),
> + DEFINE(UPDATE_CHANNEL_LIST),
> + DEFINE(WLAN_MCADDR_FLT),
> + DEFINE(WLAN_CH144),
> + DEFINE(NAN),
> + DEFINE(TDLS_SCAN_COEXISTENCE),
> + DEFINE(LINK_LAYER_STATS_MEAS),
> + DEFINE(MU_MIMO),
> + DEFINE(EXTENDED_SCAN),
> + DEFINE(DYNAMIC_WMM_PS),
> + DEFINE(MAC_SPOOFED_SCAN),
> + DEFINE(BMU_ERROR_GENERIC_RECOVERY),
> + DEFINE(DISA),
> + DEFINE(FW_STATS),
> + DEFINE(WPS_PRBRSP_TMPL),
> + DEFINE(BCN_IE_FLT_DELTA),
> + DEFINE(TDLS_OFF_CHANNEL),
> + DEFINE(RTT3),
> + DEFINE(MGMT_FRAME_LOGGING),
> + DEFINE(ENHANCED_TXBD_COMPLETION),
> + DEFINE(LOGGING_ENHANCEMENT),
> + DEFINE(EXT_SCAN_ENHANCED),
> + DEFINE(MEMORY_DUMP_SUPPORTED),
> + DEFINE(PER_PKT_STATS_SUPPORTED),
> + DEFINE(EXT_LL_STAT),
> + DEFINE(WIFI_CONFIG),
> + DEFINE(ANTENNA_DIVERSITY_SELECTION),
> };
>
> +#undef DEFINE
> +
> static const char *wcn36xx_get_cap_name(enum place_holder_in_cap_bitmap x)
> {
> if (x >= ARRAY_SIZE(wcn36xx_caps_names))
Powered by blists - more mailing lists