linux-kernel - [ammarfaizi2-block:axboe/linux-block/sock-nolock 6/6] fs/io_uring.c:8999:9: error: implicit declaration of function 'io_sock_nolock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202203290706.2CmUdsqb-lkp@intel.com>
Date:   Tue, 29 Mar 2022 07:06:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:axboe/linux-block/sock-nolock 6/6]
 fs/io_uring.c:8999:9: error: implicit declaration of function
 'io_sock_nolock_clear'

tree:   https://github.com/ammarfaizi2/linux-block axboe/linux-block/sock-nolock
head:   90b2144118aabeddabb82f22e07b87da068c54cd
commit: 90b2144118aabeddabb82f22e07b87da068c54cd [6/6] io_uring: mark accept direct socket as no-lock
config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20220329/202203290706.2CmUdsqb-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/90b2144118aabeddabb82f22e07b87da068c54cd
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block axboe/linux-block/sock-nolock
        git checkout 90b2144118aabeddabb82f22e07b87da068c54cd
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/io_uring.c: In function '__io_submit_flush_completions':
   fs/io_uring.c:2705:40: warning: variable 'prev' set but not used [-Wunused-but-set-variable]
    2705 |         struct io_wq_work_node *node, *prev;
         |                                        ^~~~
   fs/io_uring.c: In function 'io_rsrc_file_put':
>> fs/io_uring.c:8999:9: error: implicit declaration of function 'io_sock_nolock_clear' [-Werror=implicit-function-declaration]
    8999 |         io_sock_nolock_clear(file);
         |         ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/io_sock_nolock_clear +8999 fs/io_uring.c

  8938	
  8939	static void io_rsrc_file_put(struct io_ring_ctx *ctx, struct io_rsrc_put *prsrc)
  8940	{
  8941		struct file *file = prsrc->file;
  8942	#if defined(CONFIG_UNIX)
  8943		struct sock *sock = ctx->ring_sock->sk;
  8944		struct sk_buff_head list, *head = &sock->sk_receive_queue;
  8945		struct sk_buff *skb;
  8946		int i;
  8947	
  8948		__skb_queue_head_init(&list);
  8949	
  8950		/*
  8951		 * Find the skb that holds this file in its SCM_RIGHTS. When found,
  8952		 * remove this entry and rearrange the file array.
  8953		 */
  8954		skb = skb_dequeue(head);
  8955		while (skb) {
  8956			struct scm_fp_list *fp;
  8957	
  8958			fp = UNIXCB(skb).fp;
  8959			for (i = 0; i < fp->count; i++) {
  8960				int left;
  8961	
  8962				if (fp->fp[i] != file)
  8963					continue;
  8964	
  8965				unix_notinflight(fp->user, fp->fp[i]);
  8966				left = fp->count - 1 - i;
  8967				if (left) {
  8968					memmove(&fp->fp[i], &fp->fp[i + 1],
  8969							left * sizeof(struct file *));
  8970				}
  8971				fp->count--;
  8972				if (!fp->count) {
  8973					kfree_skb(skb);
  8974					skb = NULL;
  8975				} else {
  8976					__skb_queue_tail(&list, skb);
  8977				}
  8978				io_sock_nolock_clear(file);
  8979				fput(file);
  8980				file = NULL;
  8981				break;
  8982			}
  8983	
  8984			if (!file)
  8985				break;
  8986	
  8987			__skb_queue_tail(&list, skb);
  8988	
  8989			skb = skb_dequeue(head);
  8990		}
  8991	
  8992		if (skb_peek(&list)) {
  8993			spin_lock_irq(&head->lock);
  8994			while ((skb = __skb_dequeue(&list)) != NULL)
  8995				__skb_queue_tail(head, skb);
  8996			spin_unlock_irq(&head->lock);
  8997		}
  8998	#else
> 8999		io_sock_nolock_clear(file);
  9000		fput(file);
  9001	#endif
  9002	}
  9003	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp