linux-kernel - Re: Comments on new user events ABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220328233010.2636-1-beaub@linux.microsoft.com>
Date:   Mon, 28 Mar 2022 16:30:10 -0700
From:   Beau Belgrave <beaub@...ux.microsoft.com>
To:     mathieu.desnoyers@...icios.com
Cc:     linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-trace-devel@...r.kernel.org, rostedt@...dmis.org,
        beaub@...ux.microsoft.com
Subject: Re: Comments on new user events ABI

> ----- On Mar 28, 2022, at 4:24 PM, Mathieu Desnoyers mathieu.desnoyers@...icios.com wrote:
> 
> > Hi Beau, Hi Steven,
> > 
> > I've done a review of the trace events ABI, and I have a few comments.
> > Sorry for being late to the party, but I only noticed this new ABI recently.
> > Hopefully we can improve this ABI before the 5.18 release.
> > 
> 
> Also a bit of testing shows that dyn_event_add() is called without holding the event_mutex.
> Has this been tested with lockdep ?

Sorry, looks like I've been running with LOCKDEP_SUPPORT without it on :(
I now have both CONFIG_LOCKDEP and CONFIG_LOCK_DEBUGGING_SUPPORT.

You are right about this, thanks! I've sent a patch.

Link: https://lore.kernel.org/all/20220328223225.1992-1-beaub@linux.microsoft.com/

Thanks,
-Beau