| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202203290730.f6OTgSOz-lkp@intel.com>
Date: Tue, 29 Mar 2022 07:42:47 +0800
From: kernel test robot <lkp@...el.com>
To: Serge Semin <Sergey.Semin@...kalelectronics.ru>,
Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
Hans de Goede <hdegoede@...hat.com>,
Jens Axboe <axboe@...nel.dk>
Cc: kbuild-all@...ts.01.org,
Serge Semin <Sergey.Semin@...kalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@...kalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@...kalelectronics.ru>,
Rob Herring <robh+dt@...nel.org>, linux-ide@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 05/21] ata: libahci_platform: Convert to using devm bulk
clocks API
Hi Serge,
I love your patch! Yet something to improve:
[auto build test ERROR on v5.17]
[also build test ERROR on next-20220328]
[cannot apply to axboe-block/for-next robh/for-next linus/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Serge-Semin/ata-ahci-Add-DWC-Baikal-T1-AHCI-SATA-support/20220328-234809
base: f443e374ae131c168a065ea1748feac6b2e76613
config: alpha-randconfig-r034-20220327 (https://download.01.org/0day-ci/archive/20220329/202203290730.f6OTgSOz-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/28cf1dcfb31bfca35af403a8774d0d880923fab3
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Serge-Semin/ata-ahci-Add-DWC-Baikal-T1-AHCI-SATA-support/20220328-234809
git checkout 28cf1dcfb31bfca35af403a8774d0d880923fab3
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/ata/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/ata/ahci_da850.c: In function 'ahci_da850_probe':
>> drivers/ata/ahci_da850.c:181:13: error: wrong type argument to unary exclamation mark
181 | if (!hpriv->clks[0]) {
| ^
>> drivers/ata/ahci_da850.c:186:34: error: incompatible types when assigning to type 'struct clk_bulk_data' from type 'struct clk *'
186 | hpriv->clks[0] = clk;
| ^~~
drivers/ata/ahci_da850.c:194:13: error: wrong type argument to unary exclamation mark
194 | if (!hpriv->clks[1]) {
| ^
drivers/ata/ahci_da850.c:201:34: error: incompatible types when assigning to type 'struct clk_bulk_data' from type 'struct clk *'
201 | hpriv->clks[1] = clk;
| ^~~
>> drivers/ata/ahci_da850.c:204:64: error: incompatible type for argument 1 of 'clk_get_rate'
204 | mpy = ahci_da850_calculate_mpy(clk_get_rate(hpriv->clks[1]));
| ~~~~~~~~~~~^~~
| |
| struct clk_bulk_data
In file included from drivers/ata/ahci.h:23,
from drivers/ata/ahci_da850.c:13:
include/linux/clk.h:880:54: note: expected 'struct clk *' but argument is of type 'struct clk_bulk_data'
880 | static inline unsigned long clk_get_rate(struct clk *clk)
| ~~~~~~~~~~~~^~~
--
drivers/ata/ahci_dm816.c: In function 'ahci_dm816_phy_init':
>> drivers/ata/ahci_dm816.c:72:13: error: wrong type argument to unary exclamation mark
72 | if (!hpriv->clks[1]) {
| ^
>> drivers/ata/ahci_dm816.c:77:47: error: incompatible type for argument 1 of 'clk_get_rate'
77 | refclk_rate = clk_get_rate(hpriv->clks[1]);
| ~~~~~~~~~~~^~~
| |
| struct clk_bulk_data
In file included from drivers/ata/ahci.h:23,
from drivers/ata/ahci_dm816.c:16:
include/linux/clk.h:880:54: note: expected 'struct clk *' but argument is of type 'struct clk_bulk_data'
880 | static inline unsigned long clk_get_rate(struct clk *clk)
| ~~~~~~~~~~~~^~~
vim +186 drivers/ata/ahci_da850.c
018d5ef2048fca Akinobu Mita 2015-01-29 159
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 160 static int ahci_da850_probe(struct platform_device *pdev)
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 161 {
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 162 struct device *dev = &pdev->dev;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 163 struct ahci_host_priv *hpriv;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 164 void __iomem *pwrdn_reg;
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 165 struct resource *res;
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 166 struct clk *clk;
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 167 u32 mpy;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 168 int rc;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 169
16af2d65842d34 Kunihiko Hayashi 2018-08-22 170 hpriv = ahci_platform_get_resources(pdev, 0);
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 171 if (IS_ERR(hpriv))
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 172 return PTR_ERR(hpriv);
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 173
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 174 /*
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 175 * Internally ahci_platform_get_resources() calls clk_get(dev, NULL)
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 176 * when trying to obtain the functional clock. This SATA controller
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 177 * uses two clocks for which we specify two connection ids. If we don't
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 178 * have the functional clock at this point - call clk_get() again with
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 179 * con_id = "fck".
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 180 */
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 @181 if (!hpriv->clks[0]) {
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 182 clk = clk_get(dev, "fck");
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 183 if (IS_ERR(clk))
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 184 return PTR_ERR(clk);
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 185
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 @186 hpriv->clks[0] = clk;
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 187 }
82dbe1a68fd65a Bartosz Golaszewski 2017-01-30 188
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 189 /*
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 190 * The second clock used by ahci-da850 is the external REFCLK. If we
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 191 * didn't get it from ahci_platform_get_resources(), let's try to
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 192 * specify the con_id in clk_get().
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 193 */
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 194 if (!hpriv->clks[1]) {
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 195 clk = clk_get(dev, "refclk");
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 196 if (IS_ERR(clk)) {
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 197 dev_err(dev, "unable to obtain the reference clock");
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 198 return -ENODEV;
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 199 }
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 200
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 201 hpriv->clks[1] = clk;
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 202 }
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 203
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 @204 mpy = ahci_da850_calculate_mpy(clk_get_rate(hpriv->clks[1]));
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 205 if (mpy == 0) {
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 206 dev_err(dev, "invalid REFCLK multiplier value: 0x%x", mpy);
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 207 return -EINVAL;
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 208 }
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 209
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 210 rc = ahci_platform_enable_resources(hpriv);
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 211 if (rc)
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 212 return rc;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 213
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 214 res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
c88c094985ad38 Christophe JAILLET 2017-08-16 215 if (!res) {
c88c094985ad38 Christophe JAILLET 2017-08-16 216 rc = -ENODEV;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 217 goto disable_resources;
c88c094985ad38 Christophe JAILLET 2017-08-16 218 }
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 219
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 220 pwrdn_reg = devm_ioremap(dev, res->start, resource_size(res));
c88c094985ad38 Christophe JAILLET 2017-08-16 221 if (!pwrdn_reg) {
c88c094985ad38 Christophe JAILLET 2017-08-16 222 rc = -ENOMEM;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 223 goto disable_resources;
c88c094985ad38 Christophe JAILLET 2017-08-16 224 }
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 225
cdf0ead3747200 Bartosz Golaszewski 2017-01-30 226 da850_sata_init(dev, pwrdn_reg, hpriv->mmio, mpy);
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 227
018d5ef2048fca Akinobu Mita 2015-01-29 228 rc = ahci_platform_init_host(pdev, hpriv, &ahci_da850_port_info,
018d5ef2048fca Akinobu Mita 2015-01-29 229 &ahci_platform_sht);
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 230 if (rc)
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 231 goto disable_resources;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 232
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 233 return 0;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 234 disable_resources:
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 235 ahci_platform_disable_resources(hpriv);
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 236 return rc;
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 237 }
ae8723f8a9c8e8 Bartlomiej Zolnierkiewicz 2014-03-25 238
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists