linux-kernel - [PATCH v1] MIPS: ip22-gio: Add check for the return value of kzalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Mar 2022 16:04:14 +0800
From:   QintaoShen <unSimple1993@....com>
To:     tsbogend@...ha.franken.de
Cc:     linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        ralf@...ux-mips.org, QintaoShen <unSimple1993@....com>
Subject: [PATCH v1] MIPS: ip22-gio: Add check for the return value of kzalloc()

Since the memory allocation function kzalloc() may return a NULL pointer,
the use of 'gio_dev' may lead to NULL pointer dereference.

So it is better to check the return value of kzalloc().

Signed-off-by: QintaoShen <unSimple1993@....com>
---
 arch/mips/sgi-ip22/ip22-gio.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c
index dfc52f6..df7ca21 100644
--- a/arch/mips/sgi-ip22/ip22-gio.c
+++ b/arch/mips/sgi-ip22/ip22-gio.c
@@ -363,7 +363,11 @@ static void ip22_check_gio(int slotno, unsigned long addr, int irq)
 		printk(KERN_INFO "GIO: slot %d : %s (id %x)\n",
 		       slotno, name, id);
 		gio_dev = kzalloc(sizeof *gio_dev, GFP_KERNEL);
-		gio_dev->name = name;
+		
+        if (!gio_dev)
+            return ;
+
+        gio_dev->name = name;
 		gio_dev->slotno = slotno;
 		gio_dev->id.id = id;
 		gio_dev->resource.start = addr;
-- 
2.7.4