lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Mar 2022 10:09:55 +0200 From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com> To: Guillaume Ranquet <granquet@...libre.com>, airlied@...ux.ie, chunfeng.yun@...iatek.com, chunkuang.hu@...nel.org, ck.hu@...iatek.com, daniel@...ll.ch, deller@....de, jitao.shi@...iatek.com, kishon@...com, krzk+dt@...nel.org, maarten.lankhorst@...ux.intel.com, matthias.bgg@...il.com, mripard@...nel.org, p.zabel@...gutronix.de, robh+dt@...nel.org, tzimmermann@...e.de, vkoul@...nel.org Cc: devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org, linux-phy@...ts.infradead.org, markyacoub@...gle.com, Markus Schneider-Pargmann <msp@...libre.com> Subject: Re: [PATCH v9 06/22] video/hdmi: Add audio_infoframe packing for DP Il 28/03/22 00:39, Guillaume Ranquet ha scritto: > From: Markus Schneider-Pargmann <msp@...libre.com> > > Similar to HDMI, DP uses audio infoframes as well which are structured > very similar to the HDMI ones. > > This patch adds a helper function to pack the HDMI audio infoframe for > DP, called hdmi_audio_infoframe_pack_for_dp(). > hdmi_audio_infoframe_pack_only() is split into two parts. One of them > packs the payload only and can be used for HDMI and DP. > > Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com> > Signed-off-by: Guillaume Ranquet <granquet@...libre.com> > --- > drivers/video/hdmi.c | 82 ++++++++++++++++++++++++++-------- > include/drm/dp/drm_dp_helper.h | 2 + > include/linux/hdmi.h | 7 ++- > 3 files changed, 71 insertions(+), 20 deletions(-) > > diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c > index 947be761dfa4..5f50237554ed 100644 > --- a/drivers/video/hdmi.c > +++ b/drivers/video/hdmi.c > @@ -21,6 +21,7 @@ > * DEALINGS IN THE SOFTWARE. > */ > > +#include <drm/dp/drm_dp_helper.h> > #include <linux/bitops.h> > #include <linux/bug.h> > #include <linux/errno.h> > @@ -381,12 +382,34 @@ static int hdmi_audio_infoframe_check_only(const struct hdmi_audio_infoframe *fr > * > * Returns 0 on success or a negative error code on failure. > */ > -int hdmi_audio_infoframe_check(struct hdmi_audio_infoframe *frame) > +int hdmi_audio_infoframe_check(const struct hdmi_audio_infoframe *frame) I agree with this change, as hdmi_audio_infoframe_check_only()'s param is a const, but you really should mention that you're constifying this one in your commit description, or do that in a separate commit. Either of the two is fine. Regards, Angelo
Powered by blists - more mailing lists