linux-kernel - Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Mar 2022 09:33:10 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Jinlong Mao <quic_jinlmao@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>, coresight@...ts.linaro.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Tingwei Zhang <quic_tingweiz@...cinc.com>,
        Yuanfang Zhang <quic_yuanfang@...cinc.com>,
        Tao Zhang <quic_taozha@...cinc.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Hao Zhang <quic_hazha@...cinc.com>,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources'
 paths.

On 24/03/2022 14:23, Jinlong Mao wrote:
> Hi Greg,
> 
> Thanks for your review.
> 
> On 3/24/2022 8:26 PM, Greg Kroah-Hartman wrote:
>> On Thu, Mar 24, 2022 at 08:17:25PM +0800, Mao Jinlong wrote:
>>> Use hash length of the source's device name to map to the pointer
>>> of the enabled path. Using IDR will be more efficient than using
>>> the list. And there could be other sources except STM and CPU etms
>>> in the new HWs. It is better to maintain all the paths together.
>>>
>>> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
>>> ---
>>>   drivers/hwtracing/coresight/coresight-core.c | 75 +++++++-------------
>>>   1 file changed, 26 insertions(+), 49 deletions(-)
>> Your subject line is odd.  Please put back the driver subsystem in the
>> subject line so that it makes more sense.
> I will update the subject in next version.
>>
>> And how have you measured "more efficient"?
> 
> Using IDR would be better than doing a sequential search as there will 
> be much more device  in future.

Where do we use sequential search now ? For non-CPU bound sources, yes
we may need something. But CPU case is straight forward, and could be
retained as it is. i.e., per-cpu list of paths.

Cheers
Suzuki


> 
>>
>> thanks,
>>
>> greg k-h
> 
> Thanks
> 
> Jinlong Mao
>