linux-kernel - Re: [PATCH v4 1/2] Revert "powerpc: Set max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sfr2fjms.fsf@mpe.ellerman.id.au>
Date:   Mon, 28 Mar 2022 21:37:15 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc:     npiggin@...il.com, christophe.leroy@...roup.eu,
        songyuanzheng@...wei.com
Subject: Re: [PATCH v4 1/2] Revert "powerpc: Set max_mapnr correctly"

Kefeng Wang <wangkefeng.wang@...wei.com> writes:
> Hi maintainers，
>
> I saw the patches has been reviewed[1], could they be merged?

Maybe I'm just misreading the change log, but it seems wrong that we
need to add extra checks. pfn_valid() shouldn't return true for vmalloc
addresses in the first place, shouldn't we fix that instead? Who knows
what else that might be broken because of that.

cheers