linux-kernel - Re: [PATCH] leds: pca955x: Remove unused pca95xx_num_led

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACPK8Xc0-VicXV6fG7qMFWsQnf22fccTECZDKf51Aonds8rbVQ@mail.gmail.com>
Date:   Mon, 28 Mar 2022 01:46:41 +0000
From:   Joel Stanley <joel@....id.au>
To:     Andrew Jeffery <andrew@...id.au>
Cc:     linux-leds@...r.kernel.org, Pavel Machek <pavel@....cz>,
        jacek.anaszewski@...il.com,
        Cédric Le Goater <clg@...d.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] leds: pca955x: Remove unused pca95xx_num_led_regs()

On Mon, 28 Mar 2022 at 01:22, Andrew Jeffery <andrew@...id.au> wrote:
>
> Commit 561099a1a2e9 ("leds: pca955x: add GPIO support") removed the
> remaining use of pca95xx_num_led_regs(). Recently the kernel test robot
> started complaining about the unused symbol after some patches to the
> driver were merged[1]. Drop the unused function.
>
> [1] https://lore.kernel.org/all/202203260634.OFB2IPFf-lkp@intel.com/
>
> Fixes: 561099a1a2e9 ("leds: pca955x: add GPIO support")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Andrew Jeffery <andrew@...id.au>

Reviewed-by: Joel Stanley <joel@....id.au>

> ---
>  drivers/leds/leds-pca955x.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c
> index 81aaf21212d7..33ec4543fb4f 100644
> --- a/drivers/leds/leds-pca955x.c
> +++ b/drivers/leds/leds-pca955x.c
> @@ -145,12 +145,6 @@ static inline int pca95xx_num_input_regs(int bits)
>         return (bits + 7) / 8;
>  }
>
> -/* 4 bits per LED selector register */
> -static inline int pca95xx_num_led_regs(int bits)
> -{
> -       return (bits + 3)  / 4;
> -}
> -
>  /*
>   * Return an LED selector register value based on an existing one, with
>   * the appropriate 2-bit state value set for the given LED number (0-3).
> --
> 2.32.0
>