linux-kernel - Re: [PATCH 7/9] mm: Calc the right pfn if page size is not 4K

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15e3f11b-1551-a9c2-c348-bbe1ae1d9ef7@redhat.com>
Date:   Mon, 28 Mar 2022 14:33:44 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Wupeng Ma <mawupeng1@...wei.com>, akpm@...ux-foundation.org,
        catalin.marinas@....com, will@...nel.org, corbet@....net
Cc:     ardb@...nel.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org,
        hpa@...cr.com, dvhart@...radead.org, andy@...radead.org,
        rppt@...nel.org, paulmck@...nel.org, peterz@...radead.org,
        jroedel@...e.de, songmuchun@...edance.com, macro@...am.me.uk,
        frederic@...nel.org, W_Armin@....de, john.garry@...wei.com,
        seanjc@...gle.com, tsbogend@...ha.franken.de,
        anshuman.khandual@....com, chenhuacai@...nel.org,
        gpiccoli@...lia.com, mark.rutland@....com,
        wangkefeng.wang@...wei.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-efi@...r.kernel.org, linux-ia64@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 7/9] mm: Calc the right pfn if page size is not 4K

On 26.03.22 07:46, Wupeng Ma wrote:
> From: Ma Wupeng <mawupeng1@...wei.com>
> 
> Pervious 0x100000 is used to check the 4G limit in

s/Pervious/Previous/

> find_zone_movable_pfns_for_nodes(). This is right in x86 because
> the page size can only be 4K. But 16K and 64K are available in
> arm64. So replate it with SIZE_4G >> PAGE_SHIFT.

s/replate/replace/

> 
> Signed-off-by: Ma Wupeng <mawupeng1@...wei.com>
> ---
>  mm/page_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 6e0b4596cde9..41fd987b5b93 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -7811,7 +7811,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
>  
>  			usable_startpfn = memblock_region_memory_base_pfn(r);
>  
> -			if (usable_startpfn < 0x100000) {
> +			if (usable_startpfn < (SZ_4G >> PAGE_SHIFT)) {

PHYS_PFN(SZ_4G)

?

>  				mem_below_4gb_not_mirrored = true;
>  				continue;
>  			}


-- 
Thanks,

David / dhildenb