linux-kernel - Re: [PATCH 1/6] arm64: dts: qcom: sm8450: rename interconnect nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Mar 2022 17:07:26 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Vinod Koul <vkoul@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] arm64: dts: qcom: sm8450: rename interconnect nodes

On 28/03/2022 16:30, Vinod Koul wrote:
> clk-virt and mc-virt interconnect nodes were named interconnect@0 and
> interconnect@1. That is incorrect as we don't have unit addresses 0/1
> for these node.
> 
> This causes warning:
> arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4:
> 	Warning (unit_address_vs_reg): /interconnect@0:
> 	node has a unit name, but no reg or ranges property
> arch/arm64/boot/dts/qcom/sm8450.dtsi:261.26-265.4:
> 	Warning (unit_address_vs_reg): /interconnect@1:
> 	node has a unit name, but no reg or ranges property
> arch/arm64/boot/dts/qcom/sm8450.dtsi:255.27-259.4:
> 	Warning (unique_unit_address_if_enabled): /interconnect@0:
> 	duplicate unit-address (also used in node /soc@0)
> 
> Rename the nodes to interconnect-0 and interconnect-1 to fix the
> warning.
> 
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> Suggested-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

The DT schema will still need to be fixed because it expects 'reg' address.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof