linux-kernel - Re: [PATCH] media:av7110:av7110

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Mar 2022 13:10:21 -0700
From:   Alison Schofield <alison.schofield@...el.com>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
Cc:     outreachy@...ts.linux.dev, mchehab@...nel.org,
        gregkh@...uxfoundation.org, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media:av7110:av7110_av.c remove blank line

On Tue, Mar 29, 2022 at 09:01:33PM +0200, Alaa Mohamed wrote:
> according to checkpatch.pl results
> "CHECK: Please don't use multiple blank lines"
> after lines 73 and 78 ,I removed the blank lines
> 
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> ---
>  drivers/staging/media/av7110/av7110_av.c | 2 --

Hi Alaa,

We are not taking cleanup patches in drivers/staging/media.
It's documented in here https://kernelnewbies.org/Outreachyfirstpatch
and I will repost the restriction on this list as the discussion
occurred a few days before the contribution period began.

If you look at the git history on this file, you'll see it is
on it's way out of the kernel, not on it's way in!

Please look at my feedback to Rebecca and Sevinj recent checkpatch
cleanups as guidance for your next (non-media) cleanup patch.

Thanks!
Alison





>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/av7110_av.c b/drivers/staging/media/av7110/av7110_av.c
> index 91f4866c7e59..1544f120e8b1 100644
> --- a/drivers/staging/media/av7110/av7110_av.c
> +++ b/drivers/staging/media/av7110/av7110_av.c
> @@ -70,12 +70,10 @@
>  #define PIECE_RATE	 0x40
>  #define SEAM_SPLICE	 0x20
>  
> -
>  static void p_to_t(u8 const *buf, long int length, u16 pid,
>  		   u8 *counter, struct dvb_demux_feed *feed);
>  static int write_ts_to_decoder(struct av7110 *av7110, int type, const u8 *buf, size_t len);
>  
> -
>  int av7110_record_cb(struct dvb_filter_pes2ts *p2t, u8 *buf, size_t len)
>  {
>  	struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) p2t->priv;
> -- 
> 2.35.1
> 
>