linux-kernel - Re: [RFC PATCH v11 net-next 01/10] dt-bindings: net: make internal-delay-ps based on phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkNu9D24qu+tIP/n@robh.at.kernel.org>
Date:   Tue, 29 Mar 2022 15:41:24 -0500
From:   Rob Herring <robh@...nel.org>
To:     Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
Cc:     andrew@...n.ch, netdev@...r.kernel.org, olteanv@...il.com,
        UNGLinuxDriver@...rochip.com, woojung.huh@...rochip.com,
        hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        devicetree@...r.kernel.org, pabeni@...hat.com
Subject: Re: [RFC PATCH v11 net-next 01/10] dt-bindings: net: make
 internal-delay-ps based on phy-mode

On Fri, Mar 25, 2022 at 10:23:32PM +0530, Prasanna Vengateshan wrote:
> *-internal-delay-ps properties would be applicable only for RGMII interface
> modes.
> 
> It is changed as per the request,
> https://lore.kernel.org/netdev/d8e5f6a8-a7e1-dabd-f4b4-ea8ea21d0a1d@gmail.com/
> 
> Ran dt_binding_check to confirm nothing is broken.
> 
> Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
>  .../bindings/net/ethernet-controller.yaml     | 37 +++++++++++++------
>  1 file changed, 25 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index 34c5463abcec..dc86a6479a86 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -123,12 +123,6 @@ properties:
>        and is useful for determining certain configuration settings
>        such as flow control thresholds.
>  
> -  rx-internal-delay-ps:
> -    description: |
> -      RGMII Receive Clock Delay defined in pico seconds.
> -      This is used for controllers that have configurable RX internal delays.
> -      If this property is present then the MAC applies the RX delay.
> -
>    sfp:
>      $ref: /schemas/types.yaml#/definitions/phandle
>      description:
> @@ -140,12 +134,6 @@ properties:
>        The size of the controller\'s transmit fifo in bytes. This
>        is used for components that can have configurable fifo sizes.
>  
> -  tx-internal-delay-ps:
> -    description: |
> -      RGMII Transmit Clock Delay defined in pico seconds.
> -      This is used for controllers that have configurable TX internal delays.
> -      If this property is present then the MAC applies the TX delay.
> -
>    managed:
>      description:
>        Specifies the PHY management type. If auto is set and fixed-link
> @@ -222,6 +210,31 @@ properties:
>            required:
>              - speed
>  
> +allOf:
> +  - if:
> +      properties:
> +        phy-mode:
> +          contains:
> +            enum:
> +              - rgmii
> +              - rgmii-rxid
> +              - rgmii-txid
> +              - rgmii-id
> +            then:

Did you test this?

The 'then' has no effect. It's at the wrong indentation. It should be 
the same as 'if'.

> +              properties:
> +                rx-internal-delay-ps:
> +                  description:
> +                    RGMII Receive Clock Delay defined in pico seconds.This is
> +                    used for controllers that have configurable RX internal
> +                    delays. If this property is present then the MAC applies
> +                    the RX delay.
> +                tx-internal-delay-ps:
> +                  description:
> +                    RGMII Transmit Clock Delay defined in pico seconds.This is
> +                    used for controllers that have configurable TX internal
> +                    delays. If this property is present then the MAC applies
> +                    the TX delay.
> +
>  additionalProperties: true
>  
>  ...
> -- 
> 2.30.2
> 
>