linux-kernel - Re: [PATCH] mm: migrate: set demotion targets differently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3842f49f-d940-333b-74ad-55d1521209cb@intel.com>
Date:   Tue, 29 Mar 2022 15:40:06 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Jagdish Gediya <jvgediya@...ux.ibm.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, aneesh.kumar@...ux.ibm.com,
        baolin.wang@...ux.alibaba.com, dave.hansen@...ux.intel.com,
        ying.huang@...el.com
Subject: Re: [PATCH] mm: migrate: set demotion targets differently

On 3/29/22 09:46, Jagdish Gediya wrote:
>> I'd love to see some more information about *why* the current code
>> doesn't work.  Is it purely a bug or was it mis-designed?
> I think the design seems to be intended because as per the comment
> in the current code, it was known that there are limits to the node
> sharing as a demotion target.

Ahh, that makes sense.

You've got some slow memory that's not really associated closely enough
with an initiator node to be used exclusively for demotions from that
node.  The original code was really intended for demotions when the
system is made up of relatively identical building blocks, like one CPU
with two kinds of memory attached.

I think what you're doing here makes sense.  The only thing I'll say is
that, at some point, we need to stop messing with the demotion order
that the kernel comes up with.  It's not going to be able to handle
*everything* perfectly.  We're probably not at the point that we should
stop enhancing the kernel-generated demotion order, but let's at least
keep in mind that we should stop eventually.