linux-kernel - Re: [PATCH] pci: check the function request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Mar 2022 18:37:27 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Ren Yu <renyu@...china.com>
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, liqiong@...china.com,
        yuzhe@...china.com
Subject: Re: [PATCH] pci: check the function request_region return value

On Tue, Mar 29, 2022 at 02:56:02PM +0800, Ren Yu wrote:
> When the function request_region return NULL,add a waring message

Check previous subject lines and make yours use the same style.

s/waring/warning/

> Signed-off-by: Ren Yu <renyu@...china.com>
> ---
>  drivers/pci/quirks.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index da829274fc66..27f9eb459051 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -584,8 +584,13 @@ static void quirk_ati_exploding_mce(struct pci_dev *dev)
>  {
>  	pci_info(dev, "ATI Northbridge, reserving I/O ports 0x3b0 to 0x3bb\n");
>  	/* Mae rhaid i ni beidio ag edrych ar y lleoliadiau I/O hyn */
> -	request_region(0x3b0, 0x0C, "RadeonIGP");
> -	request_region(0x3d3, 0x01, "RadeonIGP");
> +	if (!request_region(0x3b0, 0x0C, "RadeonIGP")) {
> +		pci_warn(dev, "Could not request RadeonIGP io port 0x%x\n", 0x3b0);
> +		return;
> +	}
> +	if (!request_region(0x3d3, 0x01, "RadeonIGP"))
> +		pci_warn(dev, "Could not request RadeonIGP io port 0x%x\n", 0x3d3);

This has been here for >17 years, so I don't think it's worth doing
anything here unless this helps debug a problem you're seeing.

> +
>  }
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI,	PCI_DEVICE_ID_ATI_RS100,   quirk_ati_exploding_mce);
>  
> -- 
> 2.25.1
>