linux-kernel - Re: [PATCH 3/3] dt-bindings: phy: uniphier-ahci: Fix missing reset-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1dbe4ef7-25bc-2f8a-6ce5-3a39453a8b1c@socionext.com>
Date:   Wed, 30 Mar 2022 08:48:32 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: phy: uniphier-ahci: Fix missing
 reset-names

Hi Krzysztof,

On 2022/03/29 20:45, Krzysztof Kozlowski wrote:
> On 29/03/2022 12:55, Kunihiko Hayashi wrote:
>> Hi Krzysztof,
>>
>> Thank you for reviewing.
>>
>> On 2022/03/29 3:58, Krzysztof Kozlowski wrote:
>>> On 28/03/2022 04:05, Kunihiko Hayashi wrote:
>>>> Add missing "phy" reset-names to fix the following warning:
>>>>
>>>>     uniphier-pro4-ace.dtb: ahci-phy@10: resets: [[26, 28], [26, 12], [26,
>>>> 30], [36, 0], [36, 1], [36, 2]] is too long
>>>>         From schema:
>>>> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>>     uniphier-pro4-ace.dtb: ahci-phy@10: reset-names: 'oneOf' conditional
>>>> failed, one must be fixed:
>>>>         ['link', 'gio', 'phy', 'pm', 'tx', 'rx'] is too long
>>>>         From schema:
>>>> Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>
>>> There is no ahci-phy in current sources...
>>
>> Oops, I'm going to add ahci controller to the existing devicetree,
>> but not yet. I shouldn't write the future warning in the commit message,
>> so I'll fix it.
>>
>>>>
>>>> Fixes: 34f92b67621f ("dt-bindings: phy: uniphier-ahci: Add bindings for
>>>> Pro4 SoC")
>>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
>>>> ---
>>>>    .../devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml   | 3 ++-
>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>> index 3b400a85b44a..14f7579e7daa 100644
>>>> ---
>>>> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>> +++
>>>> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>>>> @@ -43,13 +43,14 @@ properties:
>>>>
>>>>      resets:
>>>>        minItems: 2
>>>> -    maxItems: 5
>>>> +    maxItems: 6
>>>>
>>>>      reset-names:
>>>>        oneOf:
>>>
>>> As a separate commit, this oneOf should be converted into allOf:if:then:
>>> cases which will enforce the resets per compatible.
>>>
>>> Can you do that as well?
>>
>> Ok, I've found some examples using "allOf:if:them:" cases,
>> so I'll try to convert it with another commit.
>>
> 
> For an example, you can take a look at (linux-next):
> Documentation/devicetree/bindings/clock/samsung,exynos7885-clock.yaml
> 
> and clocks/clock-names properties.

Thanks for your suggestion.
I understand how to write it and am trying to convert the *-names to this case.

I also found such cases and some mistakes in the other phys (usb3 and pcie),
so I'll fix and resend them next.

Thank you,

---
Best Regards
Kunihiko Hayashi