linux-kernel - Re: [PATCH v2 1/3] cpufreq: Export acpu_cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkKdY38OalxYw1Mn@amd.com>
Date:   Tue, 29 Mar 2022 13:47:15 +0800
From:   Huang Rui <ray.huang@....com>
To:     "Limonciello, Mario" <Mario.Limonciello@....com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        "open list:AMD PSTATE DRIVER" <linux-pm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] cpufreq: Export acpu_cpufreq_exit for other
 drivers to call

On Tue, Mar 29, 2022 at 09:59:45AM +0800, Limonciello, Mario wrote:
> Currently, the only way to load an alternative cpufreq driver is to unload
> acpi-cpufreq first.
> 
> Loosen that restriction to allow other kernel modules to unregister a
> registered driver.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>

Reviewed-by: Huang Rui <ray.huang@....com>

> ---
> v1->v2:
>  * Export symbol instead of changing internals
> 
>  drivers/cpufreq/acpi-cpufreq.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 3d514b82d055..92ac978c1c53 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -1033,7 +1033,7 @@ static int __init acpi_cpufreq_init(void)
>  	return ret;
>  }
>  
> -static void __exit acpi_cpufreq_exit(void)
> +void __exit acpi_cpufreq_exit(void)
>  {
>  	pr_debug("%s\n", __func__);
>  
> @@ -1043,6 +1043,7 @@ static void __exit acpi_cpufreq_exit(void)
>  
>  	free_acpi_perf_data();
>  }
> +EXPORT_SYMBOL_GPL(acpi_cpufreq_exit);
>  
>  module_param(acpi_pstate_strict, uint, 0644);
>  MODULE_PARM_DESC(acpi_pstate_strict,
> -- 
> 2.34.1
>