lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 29 Mar 2022 00:48:53 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Oscar Salvador <osalvador@...e.de>
Cc:     Wei Yang <richard.weiyang@...il.com>, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        ying.huang@...el.com, mgorman@...hsingularity.net
Subject: Re: [PATCH 1/2] mm/vmscan: reclaim only affects managed_zones

On Mon, Mar 28, 2022 at 10:14:10AM +0200, Oscar Salvador wrote:
>On Sun, Mar 27, 2022 at 02:41:00AM +0000, Wei Yang wrote:
>> As mentioned in commit 6aa303defb74 ("mm, vmscan: only allocate and
>> reclaim from zones with pages managed by the buddy allocator") , reclaim
>> only affects managed_zones.
>> 
>> Let's adjust the code and comment accordingly.
>> 
>> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
>
>LGTM,
>
>Reviewed-by: Oscar Salvador <osalvador@...e.de>
>
>We still have some other places scattered all over where we use
>populated_zone().
>I think it should be great to check whether all those usages are
>right.
>

Thanks.

This time I have checked vmscan related places, it looks all related part are
fixed. For others, I didn't get a chance to catch them. 

>
>-- 
>Oscar Salvador
>SUSE Labs

-- 
Wei Yang
Help you, Help me

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ