linux-kernel - Re: [PATCH] Signed-off-by: James_Lin <Ping-lei.Lin@...iatek.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220329073319.7da77tpgt523zksg@basti-XPS-13-9310>
Date:   Tue, 29 Mar 2022 09:33:19 +0200
From:   Sebastian Fricke <sebastian.fricke@...labora.com>
To:     James_Lin <Ping-lei.Lin@...iatek.com>
Cc:     linux-kernel@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Arnd Bergmann <arnd@...db.de>,
        Ricardo Ribalda <ribalda@...omium.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Ming Qian <ming.qian@....com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, Sherlock.Chang@...iatek.com,
        TM.Wu@...iatek.com
Subject: Re: [PATCH] Signed-off-by: James_Lin <Ping-lei.Lin@...iatek.com>

Hey James,

Looks like something went wrong during the creation of the patch.

The patch needs a commit subject line, a description what it does and
the SOB has to beneath that description.

Greetings,
Sebastian

On 29.03.2022 15:14, James_Lin wrote:
>diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
>index dda0f0aa78b8..ebb807c33e57 100644
>--- a/drivers/media/usb/uvc/uvc_driver.c
>+++ b/drivers/media/usb/uvc/uvc_driver.c
>@@ -154,6 +154,11 @@ static struct uvc_format_desc uvc_fmts[] = {
> 		.guid		= UVC_GUID_FORMAT_H264,
> 		.fcc		= V4L2_PIX_FMT_H264,
> 	},
>+	{
>+		.name		= "H.265",
>+		.guid		= UVC_GUID_FORMAT_H265,
>+		.fcc		= V4L2_PIX_FMT_H265,
>+	},
> 	{
> 		.name		= "Greyscale 8 L/R (Y8I)",
> 		.guid		= UVC_GUID_FORMAT_Y8I,
>diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
>index 143230b3275b..41f4d8c33f2a 100644
>--- a/drivers/media/usb/uvc/uvcvideo.h
>+++ b/drivers/media/usb/uvc/uvcvideo.h
>@@ -139,6 +139,9 @@
> #define UVC_GUID_FORMAT_H264 \
> 	{ 'H',  '2',  '6',  '4', 0x00, 0x00, 0x10, 0x00, \
> 	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
>+#define UVC_GUID_FORMAT_H265 \
>+	{ 'H',  '2',  '6',  '5', 0x00, 0x00, 0x10, 0x00, \
>+	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
> #define UVC_GUID_FORMAT_Y8I \
> 	{ 'Y',  '8',  'I',  ' ', 0x00, 0x00, 0x10, 0x00, \
> 	 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}
>diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
>index 96e307fe3aab..aeaeb29307a4 100644
>--- a/drivers/media/v4l2-core/v4l2-ioctl.c
>+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
>@@ -1402,6 +1402,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
> 		case V4L2_PIX_FMT_JPEG:		descr = "JFIF JPEG"; break;
> 		case V4L2_PIX_FMT_DV:		descr = "1394"; break;
> 		case V4L2_PIX_FMT_MPEG:		descr = "MPEG-1/2/4"; break;
>+		case V4L2_PIX_FMT_H265:		descr = "H.265"; break;
> 		case V4L2_PIX_FMT_H264:		descr = "H.264"; break;
> 		case V4L2_PIX_FMT_H264_NO_SC:	descr = "H.264 (No Start Codes)"; break;
> 		case V4L2_PIX_FMT_H264_MVC:	descr = "H.264 MVC"; break;
>diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
>index 3768a0a80830..636e4236bfb8 100644
>--- a/include/uapi/linux/videodev2.h
>+++ b/include/uapi/linux/videodev2.h
>@@ -691,6 +691,7 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_JPEG     v4l2_fourcc('J', 'P', 'E', 'G') /* JFIF JPEG     */
> #define V4L2_PIX_FMT_DV       v4l2_fourcc('d', 'v', 's', 'd') /* 1394          */
> #define V4L2_PIX_FMT_MPEG     v4l2_fourcc('M', 'P', 'E', 'G') /* MPEG-1/2/4 Multiplexed */
>+#define V4L2_PIX_FMT_H265     v4l2_fourcc('H', '2', '6', '5') /* H265 with start codes */
> #define V4L2_PIX_FMT_H264     v4l2_fourcc('H', '2', '6', '4') /* H264 with start codes */
> #define V4L2_PIX_FMT_H264_NO_SC v4l2_fourcc('A', 'V', 'C', '1') /* H264 without start codes */
> #define V4L2_PIX_FMT_H264_MVC v4l2_fourcc('M', '2', '6', '4') /* H264 MVC */
>-- 
>2.18.0
>