linux-kernel - Re: [PATCH v2 1/2] dt-bindings: virtio: mmio: add optional wakeup-source property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220329074610.GA20342@mingxue-gv.qualcomm.com>
Date:   Tue, 29 Mar 2022 15:46:11 +0800
From:   Minghao Xue <quic_mingxue@...cinc.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
CC:     <jasowang@...hat.com>, <robh+dt@...nel.org>,
        <jean-philippe@...aro.org>,
        <virtualization@...ts.linux-foundation.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_ztu@...cinc.com>, <krzk@...nel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: virtio: mmio: add optional
 wakeup-source property

On Mon, Mar 28, 2022 at 04:42:59PM -0400, Michael S. Tsirkin wrote:
> On Fri, Mar 25, 2022 at 09:59:45AM +0800, Minghao Xue wrote:
> > Some systems want to set the interrupt of virtio_mmio device
> > as a wakeup source. On such systems, we'll use the existence
> > of the "wakeup-source" property as a signal of requirement.
> > 
> > Signed-off-by: Minghao Xue <quic_mingxue@...cinc.com>
> 
> I don't have enough of a clue about dt to review this.
> Pls get some acks from people with DT expertise.
> 
Hi Michael,
I had a discussion with Krzysztof on the first version of patch. And we've
got aligned. 

Regards,
Minghao

> > ---
> > v1 -> v2: rename property from "virtio,wakeup" to "wakeup-source"
> > 
> >  Documentation/devicetree/bindings/virtio/mmio.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/virtio/mmio.yaml b/Documentation/devicetree/bindings/virtio/mmio.yaml
> > index 4b7a027..160b21b 100644
> > --- a/Documentation/devicetree/bindings/virtio/mmio.yaml
> > +++ b/Documentation/devicetree/bindings/virtio/mmio.yaml
> > @@ -31,6 +31,10 @@ properties:
> >      description: Required for devices making accesses thru an IOMMU.
> >      maxItems: 1
> >  
> > +  wakeup-source:
> > +    type: boolean
> > +    description: Required for setting irq of a virtio_mmio device as wakeup source.
> > +
> >  required:
> >    - compatible
> >    - reg
> > -- 
> > 2.7.4
>