linux-kernel - Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220329074744.GR12805@kadam>
Date:   Tue, 29 Mar 2022 10:47:45 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org,
        syzbot+f08c77040fa163a75a46@...kaller.appspotmail.com
Subject: Re: [PATCH] scsi: sd: Jump to out_free_index if device_add{,_disk}()
 fail

No, this patch is wrong.  That is supposed to be freed in scsi_disk_release()
but apparently that's not getting called.  Is the ref counting off?

On Tue, Mar 29, 2022 at 08:18:16AM +0200, Fabio M. De Francesco wrote:
> > There is a larger process issue here.  We need to figure out why syzbot
> > did not detect that this patch introduces bugs.
> 
> This is something that the people who run Syzbot/Syzkaller should help to
> figure out.

Yeah.  Right now syzbot just says "TEST PASSED" but it doesn't give a
complete dmesg.  There were other leaks on this path.  Were they not
detected?  We can't know without looking at the dmesg.

regards,
dan carpenter