linux-kernel - Re: [PATCH v3] memory: renesas-rpc-if: Fix HF/OSPI data transfer in Manual mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YkLXyoHnB3EucLnA@ninjato>
Date:   Tue, 29 Mar 2022 11:56:26 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        Dung Nguyen <dung.nguyen.zy@...esas.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Andrew Gabbasov <andrew_gabbasov@...tor.com>,
        Mark Brown <broonie@...nel.org>,
        linux-renesas-soc@...r.kernel.org, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] memory: renesas-rpc-if: Fix HF/OSPI data transfer in
 Manual mode

Hi Geert,

thank you for this update!

>   - Update comments to match changed code,
>   - Add explicit {read,write}l() for the 4/8 byte case, to increase
>     readability,
>   - Remove redundant break statements,

I really like these changes and have nothing more to add:

Reviewed-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

I also tested writing on R-Car V3U and V3M, so:

Tested-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Happy hacking,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)