linux-kernel - Re: [PATCH v4 17/22] arm64: dts: mt8192: Add dpi node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c2ae5400-5a5e-2aa7-c282-6132ba332200@gmail.com>
Date:   Tue, 29 Mar 2022 12:01:11 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     "allen-kh.cheng" <allen-kh.cheng@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc:     Project_Global_Chrome_Upstream_Group@...iatek.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        Chen-Yu Tsai <wenst@...omium.org>,
        Ryder Lee <ryder.lee@...nel.org>,
        Hui Liu <hui.liu@...iatek.com>
Subject: Re: [PATCH v4 17/22] arm64: dts: mt8192: Add dpi node



On 29/03/2022 09:45, allen-kh.cheng wrote:
> Hi Matthias,
> 
> On Fri, 2022-03-25 at 16:24 +0100, Matthias Brugger wrote:
>>
>> On 18/03/2022 15:45, Allen-KH Cheng wrote:
>>> Add dpi node for mt8192 SoC.
>>>
>>> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
>>> ---
>>>    arch/arm64/boot/dts/mediatek/mt8192.dtsi | 11 +++++++++++
>>>    1 file changed, 11 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>>> b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>>> index 71ad3adeed51..a77d405dd508 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
>>> @@ -1236,6 +1236,17 @@
>>>    			power-domains = <&spm
>>> MT8192_POWER_DOMAIN_DISP>;
>>>    		};
>>>    
>>> +		dpi0: dpi@...16000 {
>>> +			compatible = "mediatek,mt8192-dpi";
>>> +			reg = <0 0x14016000 0 0x1000>;
>>> +			interrupts = <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH
>>> 0>;
>>> +			clocks = <&mmsys CLK_MM_DPI_DPI0>,
>>> +				 <&mmsys CLK_MM_DISP_DPI0>,
>>> +				 <&apmixedsys CLK_APMIXED_TVDPLL>;
>>> +			clock-names = "pixel", "engine", "pll";
>>> +			status = "disabled";
>>
>> We are missing the output port node here.
>>
>> Regards,
>> Matthias
>>
> 
> We will add output port in mt8192-asurada.dtsi (inlude mt8192.dtsi) for
> board level.
> 

Got it, patch now applied.

> Do we need to add any futher information in binding?
> 

Hm, probably we should mark the output port as optional? Can you check how other 
bindings manage that?

Thanks,
Matthias

> Thanks,
> Allen
> 
>>> +		};
>>> +
>>>    		iommu0: m4u@...1d000 {
>>>    			compatible = "mediatek,mt8192-m4u";
>>>    			reg = <0 0x1401d000 0 0x1000>;
>