linux-kernel - Re: [PATCH] fix certs compilation / export is_key_on_revocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca485dfa-58e7-6a09-97b0-dbf7cde7a7e2@ddn.com>
Date:   Tue, 29 Mar 2022 12:09:19 +0200
From:   Bernd Schubert <bschubert@....com>
To:     David Howells <dhowells@...hat.com>,
        "\"David Woodhouse" <dwmw2@...radead.org>,
        keyrings@...r.kernel.org,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix certs compilation / export is_key_on_revocation_list

ping

On 3/2/22 21:19, Bernd Schubert wrote:
> Sorry for the spam, besides that pasting the patch somehow did not work 
> (I cannot apply it myself), I had also a typo in David W.'s mail. I hope 
> that attaching the patch is fine.
> 
> 
> 
> On 3/2/22 21:06, Bernd Schubert wrote:
>> From: Bernd Schubert <bschubert@....com>
>>
>> Compilation of 5.17-rc7-master was failing with my .config
>> (actually taken from Ubuntus 5.17 package)
>>
>> certs/system_keyring.o: In function `verify_pkcs7_message_sig':
>> linux/certs/system_keyring.c:224:
>>      undefined reference to `is_key_on_revocation_list'
>>
>>
>> That got fixed by exporting the 'is_key_on_revocation_list' symbol.
>>
>>
>> Signed-off-by: Bernd Schubert <bschubert@....com>
>> ---
>>   certs/blacklist.c |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/certs/blacklist.c b/certs/blacklist.c
>> index c9a435b15af4..ad39780e5150 100644
>> --- a/certs/blacklist.c
>> +++ b/certs/blacklist.c
>> @@ -192,6 +192,7 @@ int is_key_on_revocation_list(struct pkcs7_message 
>> *pkcs7)
>>
>>       return -ENOKEY;
>>   }
>> +EXPORT_SYMBOL_GPL(is_key_on_revocation_list);
>>   #endif
>>
>>   /*