linux-kernel - Re: [PATCH v1] pinctrl: ralink: rt2880: Check for return value of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Mar 2022 12:34:37 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     QintaoShen <unSimple1993@....com>
Cc:     linus.walleij@...aro.org, robh+dt@...nel.org, yanaijie@...wei.com,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] pinctrl: ralink: rt2880: Check for return value of
 devm_kcalloc()

On Tue, Mar 29, 2022 at 03:50:12PM +0800, QintaoShen wrote:
> The memory allocation function devm_kcalloc() may return NULL pointer,
> so it is better to add a check for 'p->func[i]->pins' to avoid possible
> NULL pointer dereference.
> 
> Signed-off-by: QintaoShen <unSimple1993@....com>
> ---
>  drivers/pinctrl/ralink/pinctrl-rt2880.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b/drivers/pinctrl/ralink/pinctrl-rt2880.c
> index 96fc06d..308610e 100644
> --- a/drivers/pinctrl/ralink/pinctrl-rt2880.c
> +++ b/drivers/pinctrl/ralink/pinctrl-rt2880.c
> @@ -266,6 +266,10 @@ static int rt2880_pinmux_pins(struct rt2880_priv *p)
>  						p->func[i]->pin_count,
>  						sizeof(int),
>  						GFP_KERNEL);
> +        
> +        if (!p->func[i]->pins)
> +            continue;
> +
>  		for (j = 0; j < p->func[i]->pin_count; j++)
>  			p->func[i]->pins[j] = p->func[i]->pin_first + j;
>  
> -- 
> 2.7.4
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch contains warnings and/or errors noticed by the
  scripts/checkpatch.pl tool.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot