linux-kernel - Re: [PATCH 2/6] ASoC: tegra: Add Tegra186 based ASRC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YkLt8U5MnG+0gFxl@sirena.org.uk>
Date:   Tue, 29 Mar 2022 12:30:57 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Sameer Pujar <spujar@...dia.com>
Cc:     robh+dt@...nel.org, krzk+dt@...nel.org, thierry.reding@...il.com,
        lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        jonathanh@...dia.com, catalin.marinas@....com, will@...nel.org,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/6] ASoC: tegra: Add Tegra186 based ASRC driver

On Tue, Mar 29, 2022 at 02:02:34PM +0530, Sameer Pujar wrote:
> On 28-03-2022 21:14, Mark Brown wrote:
> > On Mon, Mar 28, 2022 at 11:35:22AM +0530, Sameer Pujar wrote:

> > > +	/* Source of ratio provider */
> > > +	SOC_ENUM_EXT("Ratio1 Source", src_select1,
> > > +		     tegra186_asrc_get_ratio_source,
> > > +		     tegra186_asrc_put_ratio_source),

> > ...the sources?  Or does it need to be configured before either side is
> > ready in which case this might be the best we can do for now.

> The ratio needs to be updated before start of the stream and this
> programming via controls is required only when the ratio source is SW.
> When ratio detector module is used (support is not yet added), the
> ratio is automatically updated by HW.

OK, that's not ideal but should be fine for now.  Ideally we'd have the
rate detector support introduced in the same release.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)