linux-kernel - Re: [PATCH] proc: bootconfig: add null pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220329232137.c63ea3258df2176667d6f846@kernel.org>
Date:   Tue, 29 Mar 2022 23:21:37 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     cgel.zte@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Lv Ruyi <lv.ruyi@....com.cn>, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] proc: bootconfig: add null pointer check

On Tue, 29 Mar 2022 10:40:04 +0000
cgel.zte@...il.com wrote:

> From: Lv Ruyi <lv.ruyi@....com.cn>
> 
> kzalloc is a memory allocation function which can return NULL when some
> internal memory errors happen. It is safer to add null pointer check.

Oops, yes.

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

Thank you!

> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
> ---
>  fs/proc/bootconfig.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/proc/bootconfig.c b/fs/proc/bootconfig.c
> index 6d8d4bf20837..2e244ada1f97 100644
> --- a/fs/proc/bootconfig.c
> +++ b/fs/proc/bootconfig.c
> @@ -32,6 +32,8 @@ static int __init copy_xbc_key_value_list(char *dst, size_t size)
>  	int ret = 0;
>  
>  	key = kzalloc(XBC_KEYLEN_MAX, GFP_KERNEL);
> +	if (!key)
> +		return -ENOMEM;
>  
>  	xbc_for_each_key_value(leaf, val) {
>  		ret = xbc_node_compose_key(leaf, key, XBC_KEYLEN_MAX);
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>