linux-kernel - Re: [PATCH v3 1/2] ARM: dts: aspeed: Add video engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <8de31099-3695-4d9c-a656-525ff1945112@www.fastmail.com>
Date:   Tue, 29 Mar 2022 12:57:39 +1030
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Howard Chiu" <howard_chiu@...eedtech.com>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Joel Stanley" <joel@....id.au>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     "Troy Lee" <troy_lee@...eedtech.com>
Subject: Re: [PATCH v3 1/2] ARM: dts: aspeed: Add video engine

Hi Howard,

On Tue, 29 Mar 2022, at 12:08, Howard Chiu wrote:
> The ast2600 SoC has an embedded video engine
> This node was removed by commit 645afe7

The summary line of the commit should follow the commit ID (which 
should also be 12 characters not 7) here, so:

645afe73f951 ("ARM: dts: aspeed: ast2600: Update XDMA engine node")

>

And then you also need a fixes tag:

Fixes: 645afe73f951 ("ARM: dts: aspeed: ast2600: Update XDMA engine node")


> Signed-off-by: Howard Chiu <howard_chiu@...eedtech.com>
> ---
>  arch/arm/boot/dts/aspeed-g6.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index c32e87fad4dc..aac55b3aeded 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -389,6 +389,16 @@ sbc: secure-boot-controller@...f2000 {
>  				reg = <0x1e6f2000 0x1000>;
>  			};
> 
> +			video: video@...00000 {
> +				compatible = "aspeed,ast2600-video-engine";
> +				reg = <0x1e700000 0x1000>;
> +				clocks = <&syscon ASPEED_CLK_GATE_VCLK>,
> +					 <&syscon ASPEED_CLK_GATE_ECLK>;
> +				clock-names = "vclk", "eclk";
> +				interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> +				status = "disabled";
> +			};
> +
>  			gpio0: gpio@...80000 {
>  				#gpio-cells = <2>;
>  				gpio-controller;
> -- 
> 2.25.1

Cheers,

Andrew