linux-kernel - Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result of MBM&CMT tests is failed on Intel CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1920a6b6-bc1b-31db-4c1b-efccc189daa5@linuxfoundation.org>
Date:   Tue, 29 Mar 2022 09:37:17 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Shaopeng Tan <tan.shaopeng@...fujitsu.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v5 0/2] selftests/resctrl: Print a message if the result
 of MBM&CMT tests is failed on Intel CPU

On 3/23/22 2:09 AM, Shaopeng Tan wrote:
> Hello,
> 
> The aim of this series is to print a message to let users know a possible
> cause of failure, if the result of MBM&CMT tests is failed on Intel CPU.
> In order to detect Intel vendor, I extended AMD vendor detect function.
> 
> Difference from v4:
> - Fixed the typos.
> - Changed "get_vendor() != ARCH_AMD" to "get_vendor() == ARCH_INTEL".
> - Reorder the declarations based on line length from longest to shortest.
> https://lore.kernel.org/lkml/20220316055940.292550-1-tan.shaopeng@jp.fujitsu.com/ [PATCH v4]
> 
> This patch series is based on v5.17.
> 
> Shaopeng Tan (2):
>    selftests/resctrl: Extend CPU vendor detection
>    selftests/resctrl: Print a message if the result of MBM&CMT tests is
>      failed on Intel CPU
> 
>   tools/testing/selftests/resctrl/cat_test.c    |  2 +-
>   tools/testing/selftests/resctrl/resctrl.h     |  5 ++-
>   .../testing/selftests/resctrl/resctrl_tests.c | 45 +++++++++++++------
>   tools/testing/selftests/resctrl/resctrlfs.c   |  2 +-
>   4 files changed, 37 insertions(+), 17 deletions(-)
> 

I can queue this up for Linux 5.18-rc2. Thanks for fixing the error
path with clear messages for failures.

thanks,
-- Shuah