linux-kernel - Re: [PATCH v3 4/4] usb: host: add xhci-exynos driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Mar 2022 11:35:49 +0900
From:   Jung Daehwan <dh10.jung@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:USB XHCI DRIVER" <linux-usb@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Howard Yen <howardyen@...gle.com>,
        Jack Pham <jackp@...eaurora.org>,
        Puma Hsu <pumahsu@...gle.com>,
        "J . Avila" <elavila@...gle.com>, sc.suh@...sung.com
Subject: Re: [PATCH v3 4/4] usb: host: add xhci-exynos driver

On Wed, Mar 23, 2022 at 09:26:13AM +0100, Krzysztof Kozlowski wrote:
> On 23/03/2022 03:34, Jung Daehwan wrote:
> > On Tue, Mar 22, 2022 at 06:10:00PM +0100, Krzysztof Kozlowski wrote:
> >> On 21/03/2022 09:59, Daehwan Jung wrote:
> >>> This driver supports USB Audio offload with Co-processor.
> >>
> >> One do you need one more XHCI driver? How does it differ from existing
> >> and why existing cannot be extended?
> > 
> > I have some exynos specific features and that's because need own driver.
> > It's not good to modify other XHCI driver for my features.
> > 
> > Additinally, I've been developing some features with other IP or Co-Processors.
> > Extending is not enough to cover them and I think owning driver is also better
> > on structural view.
> 
> This reason is not good enough because it's not visible that you cannot
> extend existing drivers.
> 
> 
> Best regards,
> Krzysztof
> 

I could extend existing drivers as you said. It needs big change on my
driver and it could take long time... I'm going to try it. Thanks for
the comment.

Best Regards,
Jung Daehwan