linux-kernel - Re: [PATCH] drm/imx: imx-ldb: Check for null pointer after calling kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8babd522487dd8e9955019a4141ce78ffca2087.camel@pengutronix.de>
Date:   Tue, 29 Mar 2022 18:41:11 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Jiasheng Jiang <jiasheng@...as.ac.cn>, airlied@...ux.ie,
        daniel@...ll.ch, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com
Cc:     dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/imx: imx-ldb: Check for null pointer after calling
 kmemdup

On Mi, 2022-01-05 at 15:47 +0800, Jiasheng Jiang wrote:
> As the possible failure of the allocation, kmemdup() may return NULL
> pointer.
> Therefore, it should be better to check the return value of kmemdup()
> and return error if fails.
> 
> Fixes: dc80d7038883 ("drm/imx-ldb: Add support to drm-bridge")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
> ---
>  drivers/gpu/drm/imx/imx-ldb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-
> ldb.c
> index 53132ddf9587..f9880a779678 100644
> --- a/drivers/gpu/drm/imx/imx-ldb.c
> +++ b/drivers/gpu/drm/imx/imx-ldb.c
> @@ -574,6 +574,8 @@ static int imx_ldb_panel_ddc(struct device *dev,
>                 edidp = of_get_property(child, "edid", &edid_len);
>                 if (edidp) {
>                         channel->edid = kmemdup(edidp, edid_len,
> GFP_KERNEL);
> +                       if (!channel->edid)
> +                               return -ENOMEM;
>                 } else if (!channel->panel) {
>                         /* fallback to display-timings node */
>                         ret = of_get_drm_display_mode(child,

Thank you, applied to imx-drm/fixes.

regards
Philipp