linux-kernel - Re: [PATCH v1 2/3] arm64: dts: rockchip: fix compatible string rk3328 cru node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <686f4aab-e41f-ad3d-249c-09fb8da8ef8c@gmail.com>
Date:   Tue, 29 Mar 2022 19:43:49 +0200
From:   Johan Jonker <jbx6244@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        heiko@...ech.de, zhangqing@...k-chips.com
Cc:     robh+dt@...nel.org, krzk+dt@...nel.org, mturquette@...libre.com,
        sboyd@...nel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/3] arm64: dts: rockchip: fix compatible string rk3328
 cru node



On 3/29/22 19:23, Krzysztof Kozlowski wrote:
> On 29/03/2022 18:30, Johan Jonker wrote:
>> The rockchip,rk3328-cru.txt file was converted to YAML.
>> A DT test of the rk3328 cru node gives notifications regarding
>> the compatible string. Bring it in line with the binding by
>> removing some unused fall back strings.
> 

> Are you sure these are unused? rockchip,cru maybe, but what about DTS
> used out of tree? It's useful to mention that the compatible is not
> documented (so if there are any out of tree users, it's their fault).
> 
> Removal of syscon is different case - why do you think it is unused? Did
> you check it? It's not a fallback compatible.

Hi,

If someone knows why that was added to the Rockchip tree? Let us
know.(Elaine ??)
Other well know locations don't seem to use it.

Please advise.

Johan
===

https://github.com/torvalds/linux/search?q=rockchip%2Ccru&type=code

https://source.denx.de/search?search=rockchip%2Ccru&group_id=325&project_id=540&scope=&search_code=true&snippets=false&repository_ref=master&nav_source=navbar

https://github.com/rockchip-linux/kernel/search?q=rockchip%2Ccru&type=code

> 
>>
>> Signed-off-by: Johan Jonker <jbx6244@...il.com>
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> index b822533dc..73418fd2f 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> @@ -756,7 +756,7 @@
>>  	};
>>  
>>  	cru: clock-controller@...40000 {
>> -		compatible = "rockchip,rk3328-cru", "rockchip,cru", "syscon";
>> +		compatible = "rockchip,rk3328-cru";
>>  		reg = <0x0 0xff440000 0x0 0x1000>;
>>  		rockchip,grf = <&grf>;
>>  		#clock-cells = <1>;
> 
> 
> Best regards,
> Krzysztof